Welcome analyzer_cli to DEPS.

Welcome analyzer_cli to DEPS.

This enables us to transition the analyzer front end to use analyzer_cli.

That change is here: https://codereview.chromium.org/1100553003/

R=paulberry@google.com, ricow@google.com, rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45320

[pquitslund, 2015-04-20 21:05:43]

pquitslund@google.com changed reviewers:
+ paulberry@google.com, ricow@google.com, rnystrom@google.com

[Paul Berry, 2015-04-20 21:24:38]

lgtm, modulo whatever we decide about "pkg" vs "pkg_tested" in
https://codereview.chromium.org/1100553003/

[Bob Nystrom, 2015-04-20 22:56:30]

LGTM!

https://codereview.chromium.org/1093173004/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1093173004/diff/1/DEPS#newcode27
DEPS:27: "analyzer_cli_rev" : "@ccc093fb57da302c27966ba3321bc6f273cce7ae",
This works too but if you're publishing analyzer_cli, you may wish to use a
version tag here instead of a commit.

[pquitslund, 2015-04-20 23:08:58]

On 2015/04/20 22:56:30, Bob Nystrom wrote:
> LGTM!
> 
> https://codereview.chromium.org/1093173004/diff/1/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/1093173004/diff/1/DEPS#newcode27
> DEPS:27: "analyzer_cli_rev" : "@ccc093fb57da302c27966ba3321bc6f273cce7ae",
> This works too but if you're publishing analyzer_cli, you may wish to use a
> version tag here instead of a commit.

Thanks.  I was thinking that's were we'd end up as well.  As soon as I push a
new version, I'll change this to use a tag instead.

[ricow1, 2015-04-21 06:05:03]

lgtm

https://codereview.chromium.org/1093173004/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1093173004/diff/1/DEPS#newcode27
DEPS:27: "analyzer_cli_rev" : "@ccc093fb57da302c27966ba3321bc6f273cce7ae",
On 2015/04/20 22:56:30, Bob Nystrom wrote:
> This works too but if you're publishing analyzer_cli, you may wish to use a
> version tag here instead of a commit.

That is fine, as long as we don't change the tag to point at something new
(since this would make our assumption about reproducible builds not hold)

[Bob Nystrom, 2015-04-21 15:49:42]

On 2015/04/21 06:05:03, ricow1 wrote:
> lgtm
> 
> https://codereview.chromium.org/1093173004/diff/1/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/1093173004/diff/1/DEPS#newcode27
> DEPS:27: "analyzer_cli_rev" : "@ccc093fb57da302c27966ba3321bc6f273cce7ae",
> On 2015/04/20 22:56:30, Bob Nystrom wrote:
> > This works too but if you're publishing analyzer_cli, you may wish to use a
> > version tag here instead of a commit.
> 
> That is fine, as long as we don't change the tag to point at something new
> (since this would make our assumption about reproducible builds not hold)

We shouldn't be. The policy is that you tag a commit with a version when that
commit gets published and then never touch that tag.

- bob

[pquitslund, 2015-04-21 20:59:18]

Committed patchset #1 (id:1) manually as r45320 (presubmit successful).