Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Side by Side Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

Issue 1093153002: Fix to allow the proxy authentication dialog to appear when hosting gaia in webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Autofill is now only enabled for webviews in WebUI. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 #include "chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h" 6 #include "chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h"
7 7
8 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h" 8 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
9 #include "chrome/browser/favicon/favicon_helper.h" 9 #include "chrome/browser/favicon/favicon_helper.h"
10 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
10 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
11 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h" 12 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
13 #include "chrome/browser/ui/autofill/chrome_autofill_client.h"
14 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
12 #include "chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h" 15 #include "chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h"
16 #include "chrome/browser/ui/tab_dialogs.h"
13 #include "chrome/common/chrome_version_info.h" 17 #include "chrome/common/chrome_version_info.h"
18 #include "components/autofill/core/browser/autofill_manager.h"
14 #include "components/browsing_data/storage_partition_http_cache_data_remover.h" 19 #include "components/browsing_data/storage_partition_http_cache_data_remover.h"
15 #include "components/pdf/browser/pdf_web_contents_helper.h" 20 #include "components/pdf/browser/pdf_web_contents_helper.h"
16 #include "components/renderer_context_menu/context_menu_delegate.h" 21 #include "components/renderer_context_menu/context_menu_delegate.h"
17 #include "components/web_cache/browser/web_cache_manager.h" 22 #include "components/web_cache/browser/web_cache_manager.h"
18 #include "content/public/browser/render_process_host.h" 23 #include "content/public/browser/render_process_host.h"
19 #include "extensions/browser/api/web_request/web_request_api.h" 24 #include "extensions/browser/api/web_request/web_request_api.h"
20 #include "extensions/browser/guest_view/guest_view_event.h" 25 #include "extensions/browser/guest_view/guest_view_event.h"
21 #include "extensions/browser/guest_view/web_view/web_view_constants.h" 26 #include "extensions/browser/guest_view/web_view/web_view_constants.h"
22 27
23 #if defined(ENABLE_PRINTING) 28 #if defined(ENABLE_PRINTING)
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 printing::PrintViewManager::CreateForWebContents(contents); 100 printing::PrintViewManager::CreateForWebContents(contents);
96 printing::PrintPreviewMessageHandler::CreateForWebContents(contents); 101 printing::PrintPreviewMessageHandler::CreateForWebContents(contents);
97 #else 102 #else
98 printing::PrintViewManagerBasic::CreateForWebContents(contents); 103 printing::PrintViewManagerBasic::CreateForWebContents(contents);
99 #endif // defined(ENABLE_PRINT_PREVIEW) 104 #endif // defined(ENABLE_PRINT_PREVIEW)
100 #endif // defined(ENABLE_PRINTING) 105 #endif // defined(ENABLE_PRINTING)
101 pdf::PDFWebContentsHelper::CreateForWebContentsWithClient( 106 pdf::PDFWebContentsHelper::CreateForWebContentsWithClient(
102 contents, 107 contents,
103 scoped_ptr<pdf::PDFWebContentsHelperClient>( 108 scoped_ptr<pdf::PDFWebContentsHelperClient>(
104 new ChromePDFWebContentsHelperClient())); 109 new ChromePDFWebContentsHelperClient()));
110
111 // Autofill is currently only be enabled for webview in WebUI.
vabr (Chromium) 2015/04/22 09:53:56 typo: Remove "be".
paulmeyer 2015/04/22 17:21:06 Whoops, I changed "will" to "is currently" and bro
112 if (!web_view_guest_->owner_web_contents()->GetWebUI())
113 return;
114
115 autofill::ChromeAutofillClient::CreateForWebContents(contents);
116 autofill::ChromeAutofillClient* auto_fill_client =
117 autofill::ChromeAutofillClient::FromWebContents(contents);
118 ChromePasswordManagerClient::CreateForWebContentsWithAutofillClient(
119 contents, auto_fill_client);
120 ManagePasswordsUIController::CreateForWebContents(contents);
121 TabDialogs::CreateForWebContents(contents);
105 } 122 }
106 123
107 void ChromeWebViewGuestDelegate::OnDidCommitProvisionalLoadForFrame( 124 void ChromeWebViewGuestDelegate::OnDidCommitProvisionalLoadForFrame(
108 bool is_main_frame) { 125 bool is_main_frame) {
109 if (is_main_frame) 126 if (is_main_frame)
110 chromevox_injected_ = false; 127 chromevox_injected_ = false;
111 } 128 }
112 129
113 void ChromeWebViewGuestDelegate::OnDidInitialize() { 130 void ChromeWebViewGuestDelegate::OnDidInitialize() {
114 #if defined(OS_CHROMEOS) 131 #if defined(OS_CHROMEOS)
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 chromeos::ACCESSIBILITY_TOGGLE_SPOKEN_FEEDBACK) { 210 chromeos::ACCESSIBILITY_TOGGLE_SPOKEN_FEEDBACK) {
194 if (details.enabled) 211 if (details.enabled)
195 InjectChromeVoxIfNeeded(guest_web_contents()->GetRenderViewHost()); 212 InjectChromeVoxIfNeeded(guest_web_contents()->GetRenderViewHost());
196 else 213 else
197 chromevox_injected_ = false; 214 chromevox_injected_ = false;
198 } 215 }
199 } 216 }
200 #endif 217 #endif
201 218
202 } // namespace extensions 219 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698