Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1093143004: fixes #52, fields shadowing getters/setters or other fields (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly
Modified:
5 years, 8 months ago
Reviewers:
Leaf, Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #52, fields shadowing getters/setters or other fields This is an alternate approach

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+638 lines, -373 lines) Patch
M lib/runtime/dart/_foreign_helper.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/_internal.js View 4 chunks +12 lines, -12 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 4 chunks +19 lines, -19 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 21 chunks +59 lines, -59 lines 0 comments Download
M lib/runtime/dart/_native_typed_data.js View 1 10 chunks +34 lines, -33 lines 0 comments Download
M lib/runtime/dart/async.js View 6 chunks +9 lines, -9 lines 0 comments Download
M lib/runtime/dart/collection.js View 10 chunks +33 lines, -33 lines 0 comments Download
M lib/runtime/dart/convert.js View 5 chunks +11 lines, -11 lines 0 comments Download
M lib/runtime/dart/core.js View 28 chunks +61 lines, -61 lines 0 comments Download
M lib/runtime/dart/isolate.js View 3 chunks +6 lines, -6 lines 0 comments Download
M lib/runtime/dart/math.js View 3 chunks +8 lines, -8 lines 0 comments Download
M lib/runtime/dart/typed_data.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart_runtime.js View 1 chunk +37 lines, -0 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 23 chunks +105 lines, -66 lines 0 comments Download
A lib/src/codegen/js_field_storage.dart View 1 1 chunk +71 lines, -0 lines 0 comments Download
M test/codegen/expect/BenchmarkBase.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/DeltaBlue.js View 8 chunks +19 lines, -19 lines 0 comments Download
M test/codegen/expect/cascade.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen/expect/constructors.js View 2 chunks +8 lines, -8 lines 0 comments Download
A test/codegen/expect/fields.js View 1 chunk +71 lines, -0 lines 0 comments Download
A test/codegen/expect/fields.txt View 1 chunk +1 line, -0 lines 0 comments Download
M test/codegen/expect/fieldtest.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/expect/methods.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen/expect/names.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/opassign.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/sunflower/dom.js View 2 chunks +9 lines, -9 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/expect/temps.js View 1 chunk +3 lines, -3 lines 0 comments Download
A test/codegen/fields.dart View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Jennifer Messerly
thoughts on this? it's a variant from the other CL. Instead it makes initializers ugly, ...
5 years, 8 months ago (2015-04-20 22:00:01 UTC) #2
Jennifer Messerly
5 years, 8 months ago (2015-04-20 22:58:09 UTC) #3 
fyi: I'm redoing this one with a sealed assumption.

(I also noticed an issue with how this computes the virtualField call... it's
not marking the leaf node)

Powered by Google App Engine
This is Rietveld 408576698