Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: third_party/libevent/nacl_nonsfi/signal_stub.c

Issue 1093113002: Stub out libevent's signal.c. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libevent/nacl_nonsfi/signal_stub.c
diff --git a/third_party/libevent/nacl_nonsfi/signal_stub.c b/third_party/libevent/nacl_nonsfi/signal_stub.c
new file mode 100644
index 0000000000000000000000000000000000000000..56208bc13e79c9fd5d4866e07ac248f62b4acb0f
--- /dev/null
+++ b/third_party/libevent/nacl_nonsfi/signal_stub.c
@@ -0,0 +1,35 @@
+/*
+ * Copyright 2015 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+/*
+ * In nacl_helper_nonsfi, socketpair() is unavailable. In libevent, it is used
+ * to notify signal handler invocation, which is unused in nacl_helper_nonsfi.
Mark Seaborn 2015/04/24 16:01:54 Nit: "notify of a signal handler invocation"?
hidehiko 2015/04/27 16:47:21 Done.
+ * Unfortunately, there is no macro to disable the feature, so we stub out
+ * the signal module entirely.
+ */
+
+struct event_base;
Mark Seaborn 2015/04/24 16:01:54 Nit: #include libevent/evsignal.h instead. That w
hidehiko 2015/04/27 16:47:21 Done.
+struct event;
+
+struct event_base *evsignal_base = 0;
+
+int evsignal_init(struct event_base *base) {
+ return -1;
Mark Seaborn 2015/04/24 16:01:54 Nit: This indicates an error. Though none of the
hidehiko 2015/04/27 16:47:21 Done.
+}
+
+void evsignal_process(struct event_base *base) {
+}
+
+int evsignal_add(struct event *event) {
+ return -1;
+}
+
+int evsignal_del(struct event *event) {
+ return -1;
+}
+
+void evsignal_dealloc(struct event_base *base) {
+}
« third_party/libevent/README.chromium ('K') | « third_party/libevent/libevent_nacl_nonsfi.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698