Stub out libevent's signal.c.

Stub out libevent's signal.c.

In libevent, socketpair() is used. However, it will be prohibited
by seccomp-bpf in nacl_helper_nonsfi. As its preparation, this CL
stubs out signal.c, which is the only module calling socketpair().

TEST=Ran bots.
BUG=358417
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_trusty32_rel,linux_arm
TBR=darin@chromium.org

Committed: https://crrev.com/3029d2b48c15ea0f15e918d705ca6863d3e2172b
Cr-Commit-Position: refs/heads/master@{#327213}

[hidehiko, 2015-04-20 13:54:42]

hidehiko@chromium.org changed reviewers:
+ mseaborn@chromium.org

[hidehiko, 2015-04-20 13:54:42]

PTAL.

Note: failing tests look not related.

[hidehiko, 2015-04-21 16:38:48]

On 2015/04/20 13:54:42, hidehiko wrote:
> PTAL.
> 
> Note: failing tests look not related.

ping.

[hidehiko, 2015-04-22 15:06:47]

On 2015/04/21 16:38:48, hidehiko wrote:
> On 2015/04/20 13:54:42, hidehiko wrote:
> > PTAL.
> > 
> > Note: failing tests look not related.
> 
> ping.

ping?

[hidehiko, 2015-04-23 11:53:13]

On 2015/04/22 15:06:47, hidehiko wrote:
> On 2015/04/21 16:38:48, hidehiko wrote:
> > On 2015/04/20 13:54:42, hidehiko wrote:
> > > PTAL.
> > > 
> > > Note: failing tests look not related.
> > 
> > ping.
> 
> ping?

ping?

[Mark Seaborn, 2015-04-24 16:01:54]

LGTM

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/RE...
File third_party/libevent/README.chromium (right):

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/RE...
third_party/libevent/README.chromium:27: 9) Stub out signal.c for
nacl_helper_nonsfi. socketpair() is prohibited
Nit: "will be prohibited" instead?  (And update when you change the sandbox.)

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
File third_party/libevent/nacl_nonsfi/signal_stub.c (right):

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
third_party/libevent/nacl_nonsfi/signal_stub.c:9: * to notify signal handler
invocation, which is unused in nacl_helper_nonsfi.
Nit: "notify of a signal handler invocation"?

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
third_party/libevent/nacl_nonsfi/signal_stub.c:14: struct event_base;
Nit: #include libevent/evsignal.h instead.

That way you get a check that the functions below have the right type
signatures.

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
third_party/libevent/nacl_nonsfi/signal_stub.c:20: return -1;
Nit: This indicates an error.  Though none of the callers actually check the
return value. :-(  Should probably be "return 0" instead.

[hidehiko, 2015-04-27 16:47:21]

Thank you for review. Submitting.

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/RE...
File third_party/libevent/README.chromium (right):

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/RE...
third_party/libevent/README.chromium:27: 9) Stub out signal.c for
nacl_helper_nonsfi. socketpair() is prohibited
On 2015/04/24 16:01:54, Mark Seaborn wrote:
> Nit: "will be prohibited" instead?  (And update when you change the sandbox.)

Done.

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
File third_party/libevent/nacl_nonsfi/signal_stub.c (right):

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
third_party/libevent/nacl_nonsfi/signal_stub.c:9: * to notify signal handler
invocation, which is unused in nacl_helper_nonsfi.
On 2015/04/24 16:01:54, Mark Seaborn wrote:
> Nit: "notify of a signal handler invocation"?

Done.

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
third_party/libevent/nacl_nonsfi/signal_stub.c:14: struct event_base;
On 2015/04/24 16:01:54, Mark Seaborn wrote:
> Nit: #include libevent/evsignal.h instead.
> 
> That way you get a check that the functions below have the right type
> signatures.

Done.

https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
third_party/libevent/nacl_nonsfi/signal_stub.c:20: return -1;
On 2015/04/24 16:01:54, Mark Seaborn wrote:
> Nit: This indicates an error.  Though none of the callers actually check the
> return value. :-(  Should probably be "return 0" instead.

Done.

[hidehiko, 2015-04-27 16:53:02]

On 2015/04/27 16:47:21, hidehiko wrote:
> Thank you for review. Submitting.
> 
>
https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/RE...
> File third_party/libevent/README.chromium (right):
> 
>
https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/RE...
> third_party/libevent/README.chromium:27: 9) Stub out signal.c for
> nacl_helper_nonsfi. socketpair() is prohibited
> On 2015/04/24 16:01:54, Mark Seaborn wrote:
> > Nit: "will be prohibited" instead?  (And update when you change the
sandbox.)
> 
> Done.
> 
>
https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
> File third_party/libevent/nacl_nonsfi/signal_stub.c (right):
> 
>
https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
> third_party/libevent/nacl_nonsfi/signal_stub.c:9: * to notify signal handler
> invocation, which is unused in nacl_helper_nonsfi.
> On 2015/04/24 16:01:54, Mark Seaborn wrote:
> > Nit: "notify of a signal handler invocation"?
> 
> Done.
> 
>
https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
> third_party/libevent/nacl_nonsfi/signal_stub.c:14: struct event_base;
> On 2015/04/24 16:01:54, Mark Seaborn wrote:
> > Nit: #include libevent/evsignal.h instead.
> > 
> > That way you get a check that the functions below have the right type
> > signatures.
> 
> Done.
> 
>
https://codereview.chromium.org/1093113002/diff/20001/third_party/libevent/na...
> third_party/libevent/nacl_nonsfi/signal_stub.c:20: return -1;
> On 2015/04/24 16:01:54, Mark Seaborn wrote:
> > Nit: This indicates an error.  Though none of the callers actually check the
> > return value. :-(  Should probably be "return 0" instead.
> 
> Done.

Following the instruction in third_party/OWNERS,
TBR=darin@.

Sending this to CQ.

[hidehiko, 2015-04-27 16:53:09]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2015-04-27 16:53:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org
Link to the patchset: https://codereview.chromium.org/1093113002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-04-27 16:53:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1093113002/60001

[commit-bot: I haz the power, 2015-04-27 20:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 20:55:47]

Try jobs failed on following builders:
  linux_chromium_trusty32_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[hidehiko, 2015-04-28 01:27:44]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2015-04-28 01:27:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1093113002/60001

[commit-bot: I haz the power, 2015-04-28 01:28:57]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-28 01:29:42]

Patchset 4 (id:??) landed as
https://crrev.com/3029d2b48c15ea0f15e918d705ca6863d3e2172b
Cr-Commit-Position: refs/heads/master@{#327213}