Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: runtime/vm/service_event.h

Issue 1093043004: Do not JSON encode the 'result' of a service rpc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service/vmservice.dart ('k') | runtime/vm/service_event.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service_event.h
diff --git a/runtime/vm/service_event.h b/runtime/vm/service_event.h
index c7f41e8e118df8b772a02182a9209c9eb2880a7a..4de7aa4c9419ab50b8970c13f07f11499c357bff 100644
--- a/runtime/vm/service_event.h
+++ b/runtime/vm/service_event.h
@@ -29,6 +29,8 @@ class ServiceEvent {
kBreakpointResolved,
kBreakpointRemoved,
+ kGC,
+
kIllegal,
};
@@ -37,7 +39,8 @@ class ServiceEvent {
type_(event_type),
breakpoint_(NULL),
top_frame_(NULL),
- exception_(NULL) {}
+ exception_(NULL),
+ gc_stats_(NULL) {}
explicit ServiceEvent(const DebuggerEvent* debugger_event);
@@ -75,6 +78,14 @@ class ServiceEvent {
exception_ = exception;
}
+ const Heap::GCStats* gc_stats() const {
+ return gc_stats_;
+ }
+
+ void set_gc_stats(const Heap::GCStats* gc_stats) {
+ gc_stats_ = gc_stats;
+ }
+
void PrintJSON(JSONStream* js) const;
static const char* EventTypeToCString(EventType type);
@@ -85,6 +96,7 @@ class ServiceEvent {
SourceBreakpoint* breakpoint_;
ActivationFrame* top_frame_;
const Object* exception_;
+ const Heap::GCStats* gc_stats_;
};
} // namespace dart
« no previous file with comments | « runtime/vm/service/vmservice.dart ('k') | runtime/vm/service_event.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698