Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: runtime/vm/service/client.dart

Issue 1093043004: Do not JSON encode the 'result' of a service rpc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service.cc ('k') | runtime/vm/service/message.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service/client.dart
diff --git a/runtime/vm/service/client.dart b/runtime/vm/service/client.dart
index 0d0b253f0fa9de64cd2a23634590e0b2e65db152..56051f8deaf13c873ffb2e0bc2ac98767372f1cd 100644
--- a/runtime/vm/service/client.dart
+++ b/runtime/vm/service/client.dart
@@ -25,16 +25,16 @@ abstract class Client {
// Send message to service.
service.route(message).then((response) {
// Call post when the response arrives.
- post(seq, response);
+ post(response);
});
} catch (e, st) {
message.setErrorResponse('Internal error: $e');
- post(seq, message.response);
+ post(message.response);
}
}
// Sends a result to the client. Implemented in subclasses.
- void post(var seq, dynamic result);
+ void post(dynamic result);
dynamic toJson() {
return {
« no previous file with comments | « runtime/vm/service.cc ('k') | runtime/vm/service/message.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698