runtime/observatory/lib/service.dart - Issue 1093043004: Do not JSON encode the 'result' of a service rpc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/service.dart

Issue 1093043004: Do not JSON encode the 'result' of a service rpc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/observatory/lib/service.dart

diff --git a/runtime/observatory/lib/service.dart b/runtime/observatory/lib/service.dart

index 51765bc553585c980f79544f7e11c246561ac4ba..c1af206e565256e8e0d456ce7be446d185f67cad 100644

--- a/runtime/observatory/lib/service.dart

+++ b/runtime/observatory/lib/service.dart

@@ -5,7 +5,6 @@

library service;

import 'dart:async';

-import 'dart:convert';

import 'dart:typed_data';

import 'package:logging/logging.dart';

« no previous file with comments | « runtime/bin/vmservice/server.dart ('k') | runtime/observatory/lib/service_common.dart » ('j') | no next file with comments »