mojo/services/sensors/public/interfaces/sensors.mojom - Issue 1093033002: Add sensors application to mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/services/sensors/public/interfaces/sensors.mojom

Issue 1093033002: Add sensors application to mojo (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Support both SkyDemo and mojo_shell Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module sensors;	5 module sensors;

6	6

7 enum SensorType {	7 enum SensorType {

8 ACCELEROMETER,	8 ACCELEROMETER,

9 AMBIENT_TEMPERATURE,	9 AMBIENT_TEMPERATURE,

10 GAME_ROTATION_VECTOR,	10 GAME_ROTATION_VECTOR,

(...skipping 20 matching lines...) Expand all Loading...
31 int64 time_stamp;	31 int64 time_stamp;

32 array<float> values;	32 array<float> values;

33 };	33 };

34	34

35 interface SensorListener {	35 interface SensorListener {

36 OnAccuracyChanged(int32 accuracy);	36 OnAccuracyChanged(int32 accuracy);

37 OnSensorChanged(SensorData data);	37 OnSensorChanged(SensorData data);

38 };	38 };

39	39

40 interface SensorService {	40 interface SensorService {

41 AddListener(SensorType type, SensorListener listener);	41 AddListener(SensorType type, SensorListener listener);
	qsr 2015/04/21 08:28:45 I though we didn't want to use the observer patter I though we didn't want to use the observer pattern because of performance issue. DaveMoore 2015/04/21 15:00:07 This was lifted as is from the Sky implementation. Show quoted text On 2015/04/21 08:28:45, qsr wrote: > I though we didn't want to use the observer pattern because of performance > issue. This was lifted as is from the Sky implementation. I can explore better approaches, but I'd rather do that in another cl after we move it here. qsr 2015/04/21 15:59:32 Ok. Let's see that in another CL. Show quoted text On 2015/04/21 15:00:07, DaveMoore wrote: > On 2015/04/21 08:28:45, qsr wrote: > > I though we didn't want to use the observer pattern because of performance > > issue. > > This was lifted as is from the Sky implementation. I can explore better > approaches, but I'd rather do that in another cl after we move it here. Ok. Let's see that in another CL.
42 };	42 };

OLD	NEW

« no previous file with comments | « mojo/services/sensors/public/interfaces/BUILD.gn ('k') | services/BUILD.gn » ('j') | services/sensors/org/chromium/mojo/sensors/SensorServiceImpl.java » ('J')