Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 109303006: Revert "Remove flag track-allocation-sites." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1698 matching lines...) Expand 10 before | Expand all | Expand 10 after
1709 int length = subexprs->length(); 1709 int length = subexprs->length();
1710 Handle<FixedArray> constant_elements = expr->constant_elements(); 1710 Handle<FixedArray> constant_elements = expr->constant_elements();
1711 ASSERT_EQ(2, constant_elements->length()); 1711 ASSERT_EQ(2, constant_elements->length());
1712 ElementsKind constant_elements_kind = 1712 ElementsKind constant_elements_kind =
1713 static_cast<ElementsKind>(Smi::cast(constant_elements->get(0))->value()); 1713 static_cast<ElementsKind>(Smi::cast(constant_elements->get(0))->value());
1714 bool has_constant_fast_elements = 1714 bool has_constant_fast_elements =
1715 IsFastObjectElementsKind(constant_elements_kind); 1715 IsFastObjectElementsKind(constant_elements_kind);
1716 Handle<FixedArrayBase> constant_elements_values( 1716 Handle<FixedArrayBase> constant_elements_values(
1717 FixedArrayBase::cast(constant_elements->get(1))); 1717 FixedArrayBase::cast(constant_elements->get(1)));
1718 1718
1719 AllocationSiteMode allocation_site_mode = TRACK_ALLOCATION_SITE; 1719 AllocationSiteMode allocation_site_mode = FLAG_track_allocation_sites
1720 ? TRACK_ALLOCATION_SITE : DONT_TRACK_ALLOCATION_SITE;
1720 if (has_constant_fast_elements && !FLAG_allocation_site_pretenuring) { 1721 if (has_constant_fast_elements && !FLAG_allocation_site_pretenuring) {
1721 // If the only customer of allocation sites is transitioning, then 1722 // If the only customer of allocation sites is transitioning, then
1722 // we can turn it off if we don't have anywhere else to transition to. 1723 // we can turn it off if we don't have anywhere else to transition to.
1723 allocation_site_mode = DONT_TRACK_ALLOCATION_SITE; 1724 allocation_site_mode = DONT_TRACK_ALLOCATION_SITE;
1724 } 1725 }
1725 1726
1726 Heap* heap = isolate()->heap(); 1727 Heap* heap = isolate()->heap();
1727 if (has_constant_fast_elements && 1728 if (has_constant_fast_elements &&
1728 constant_elements_values->map() == heap->fixed_cow_array_map()) { 1729 constant_elements_values->map() == heap->fixed_cow_array_map()) {
1729 // If the elements are already FAST_*_ELEMENTS, the boilerplate cannot 1730 // If the elements are already FAST_*_ELEMENTS, the boilerplate cannot
(...skipping 3178 matching lines...) Expand 10 before | Expand all | Expand 10 after
4908 4909
4909 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 4910 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
4910 Assembler::target_address_at(call_target_address)); 4911 Assembler::target_address_at(call_target_address));
4911 return OSR_AFTER_STACK_CHECK; 4912 return OSR_AFTER_STACK_CHECK;
4912 } 4913 }
4913 4914
4914 4915
4915 } } // namespace v8::internal 4916 } } // namespace v8::internal
4916 4917
4917 #endif // V8_TARGET_ARCH_IA32 4918 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698