Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: content/browser/frame_host/navigator_impl.h

Issue 1092973002: Revert of PlzNavigate: move ownership of the NavigationRequest to the FrameTreeNode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.h
diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h
index 3c46500f8afe1ee55831e6c7542be3f9226e3376..301a758f4f14796358e8cebbbe4f81dd74194515 100644
--- a/content/browser/frame_host/navigator_impl.h
+++ b/content/browser/frame_host/navigator_impl.h
@@ -88,6 +88,11 @@
void CancelNavigation(FrameTreeNode* frame_tree_node) override;
bool IsWaitingForBeforeUnloadACK(FrameTreeNode* frame_tree_node) override;
+ // PlzNavigate
+ // Returns the navigation request for a given node. Used in tests.
+ NavigationRequest* GetNavigationRequestForNodeForTesting(
+ FrameTreeNode* frame_tree_node);
+
private:
// Holds data used to track browser side navigation metrics.
struct NavigationMetricsData;
@@ -137,6 +142,11 @@
scoped_ptr<NavigatorImpl::NavigationMetricsData> navigation_data_;
+ // PlzNavigate: used to track the various ongoing NavigationRequests in the
+ // different FrameTreeNodes, based on the frame_tree_node_id.
+ typedef base::ScopedPtrHashMap<int64, NavigationRequest> NavigationRequestMap;
+ NavigationRequestMap navigation_request_map_;
+
DISALLOW_COPY_AND_ASSIGN(NavigatorImpl);
};
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698