Remove CSSPropertyParser::inViewport method

Remove CSSPropertyParser::inViewport method

Remove CSSPropertyParser::inViewport method since with the
new CSS parser enabled we can rely on m_ruleType to be set
correctly.

BUG=489144, 404023
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195569

[rwlbuis, 2015-04-17 18:26:24]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-04-17 18:26:25]

PTAL

[Timothy Loh, 2015-04-18 00:56:59]

We can't do this. We might need to revert to the Bison parser if we detect any
major regressions (e.g. increased crashes), and this would break that codepath.

[rwlbuis, 2015-04-21 01:53:44]

On 2015/04/18 00:56:59, Timothy Loh wrote:
> We can't do this. We might need to revert to the Bison parser if we detect any
> major regressions (e.g. increased crashes), and this would break that
codepath.

I see. But could there be any point where it is safe to do this? I'd really like
to use the opportunity of the new CSS parser to refactor/improve/remove code at
some point.

[Timothy Loh, 2015-04-21 02:58:06]

On 2015/04/21 01:53:44, rwlbuis wrote:
> On 2015/04/18 00:56:59, Timothy Loh wrote:
> > We can't do this. We might need to revert to the Bison parser if we detect
any
> > major regressions (e.g. increased crashes), and this would break that
> codepath.
> 
> I see. But could there be any point where it is safe to do this? I'd really
like
> to use the opportunity of the new CSS parser to refactor/improve/remove code
at
> some point.

Yeah I'll probably delete the Bison parser some time in the next couple of
weeks. Just need to be sure there aren't any problems with the new parser.

[rwlbuis, 2015-04-21 10:52:25]

On 2015/04/21 02:58:06, Timothy Loh wrote:
> On 2015/04/21 01:53:44, rwlbuis wrote:
> > On 2015/04/18 00:56:59, Timothy Loh wrote:
> > > We can't do this. We might need to revert to the Bison parser if we detect
> any
> > > major regressions (e.g. increased crashes), and this would break that
> > codepath.
> > 
> > I see. But could there be any point where it is safe to do this? I'd really
> like
> > to use the opportunity of the new CSS parser to refactor/improve/remove code
> at
> > some point.
> 
> Yeah I'll probably delete the Bison parser some time in the next couple of
> weeks. Just need to be sure there aren't any problems with the new parser.

Great, I'll keep this one closed until then.

[rwlbuis, 2015-05-19 21:46:25]

PTAL, this one should make more sense now that the old bison parser is gone.

[Timothy Loh, 2015-05-19 23:33:38]

On 2015/05/19 21:46:25, rwlbuis wrote:
> PTAL, this one should make more sense now that the old bison parser is gone.

lgtm

[rwlbuis, 2015-05-20 00:15:17]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-05-20 00:21:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1092963002/20001

[commit-bot: I haz the power, 2015-05-20 02:02:01]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195569