chrome/browser/extensions/api/developer_private/developer_private_mangle.cc - Issue 1092953004: [Extensions] Update developerPrivate API to use base-64 data urls for icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

Issue 1092953004: [Extensions] Update developerPrivate API to use base-64 data urls for icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/developer_private/developer_private_api.cc ('K') | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/developer_private/extension_info_generator.h » ('j') | chrome/browser/extensions/api/developer_private/extension_info_generator.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc b/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

index aa1bcdbda2157aa2a9481988a0a0a4e5ab914b67..0dde6e6953d0ed2d1c284ea72a168bc26bae131f 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_mangle.cc

@@ -54,6 +54,8 @@ linked_ptr<api::developer_private::ItemInfo> MangleExtensionInfo(

result->allow_file_access = info.file_access.is_enabled;

result->wants_file_access = info.file_access.is_active;

+ result->icon_url = info.icon_url;

result->incognito_enabled = info.incognito_access.is_active;

result->allow_incognito = info.incognito_access.is_enabled;