[Extensions] Update developerPrivate API to use base-64 data urls for icons

chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(dbeam): test for loading upacked extensions?
 
 GEN('#include "chrome/browser/ui/webui/extensions/' +
     'extension_settings_browsertest.h"');
 
 // chrome/test/data/extensions/good.crx's extension ID. good.crx is loaded by
@@ skipping 133 matching lines @@
     // Show the dialog, which triggers a chrome.send() for metrics purposes.
     cr.dispatchSimpleEvent($('pack-extension'), 'click');
     assertTrue($('pack-extension-overlay').classList.contains('showing'));
     this.nextStep();
   };
 
   this.steps = [this.waitForPageLoad, testPackExtenion, testDone];
   this.nextStep();
 });
 
+/**
+ * @param {chrome.developerPrivate.EventType} eventType
+ * @param {function():void} callback
+ * @constructor
+ */
+function UpdateListener(eventType, callback) {
+  this.callback_ = callback;
+  this.eventType_ = eventType;
+  this.onItemStateChangedListener_ = this.onItemStateChanged_.bind(this);
+  chrome.developerPrivate.onItemStateChanged.addListener(
+      this.onItemStateChangedListener_);
+}
+
+UpdateListener.prototype = {
+  /** @private */
+  onItemStateChanged_: function(data) {
+    if (this.eventType_ == data.event_type) {
+      window.setTimeout(function() {
+        chrome.developerPrivate.onItemStateChanged.removeListener(
+            this.onItemStateChangedListener_);
+        this.callback_();
+      }.bind(this), 0);
+    }
+  }
+};
+
 function BasicExtensionSettingsWebUITest() {}
 
 BasicExtensionSettingsWebUITest.prototype = {
   __proto__: ExtensionSettingsWebUITest.prototype,
 
   /** @override */
   testGenPreamble: function() {
     // Install multiple types of extensions to ensure we handle each type.
     // TODO(devlin): There are more types to add here.
     GEN('  InstallGoodExtension();');
     GEN('  InstallErrorsExtension();');
     GEN('  InstallSharedModule();');
     GEN('  InstallPackagedApp();');
 
     GEN('  SetAutoConfirmUninstall();');
   },
 
   /** @protected */
   verifyDisabledWorks: function() {
-    chrome.management.setEnabled(GOOD_CRX_ID, false, function() {
+    var listener = new UpdateListener(
+        chrome.developerPrivate.EventType.UNLOADED,
+        function() {
       var node = getRequiredElement(GOOD_CRX_ID);
       assertTrue(node.classList.contains('inactive-extension'));
       this.nextStep();
     }.bind(this));
+    chrome.management.setEnabled(GOOD_CRX_ID, false);
   },
 
   /** @protected */
   verifyEnabledWorks: function() {
-    chrome.management.setEnabled(GOOD_CRX_ID, true, function() {
+    var listener = new UpdateListener(
+        chrome.developerPrivate.EventType.LOADED,
+        function() {
       var node = getRequiredElement(GOOD_CRX_ID);
       assertFalse(node.classList.contains('inactive-extension'));
       this.nextStep();
     }.bind(this));
+    chrome.management.setEnabled(GOOD_CRX_ID, true);
   },
 
   /** @protected */
   verifyUninstallWorks: function() {
-    var next = this.nextStep.bind(this);
+    var listener = new UpdateListener(
+        chrome.developerPrivate.EventType.UNINSTALLED,
+        function() {
+      assertEquals(null, $(GOOD_CRX_ID));
+      this.nextStep();
+    }.bind(this));
     chrome.test.runWithUserGesture(function() {
-      chrome.management.uninstall(GOOD_CRX_ID, function() {
-        assertEquals(null, $(GOOD_CRX_ID));
-        next();
-      });
+      chrome.management.uninstall(GOOD_CRX_ID);
     });
   },
 };
 
 // Verify that developer mode doesn't change behavior when the number of
 // extensions changes.
 TEST_F('BasicExtensionSettingsWebUITest', 'testDeveloperModeManyExtensions',
        function() {
   this.testDeveloperMode();
 });
@@ skipping 176 matching lines @@
 
   /** @override */
   browsePreload: ExtensionSettingsWebUITest.prototype.browsePreload +
       '?options=' + GOOD_CRX_ID,
 };
 
 TEST_F('OptionsDialogExtensionSettingsWebUITest', 'testAccessibility',
        function() {
   this.emptyTestForAccessibility();
 });