Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1092933006: Revert of Center permission bubble if location bar is hidden in MacOS. (Closed)

Created:
5 years, 8 months ago by Justin Donnelly
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Center permission bubble if location bar is hidden in MacOS. (patchset #19 id:360001 of https://codereview.chromium.org/986333006/) Reason for revert: I believe this is causing the Mac ASan 64 Tests (1) bot to fail: ==56836==ERROR: AddressSanitizer: stack-use-after-return on address 0x00011a38dc78 at pc 0x000104e8028f bp 0x7fff5f6e5600 sp 0x7fff5f6e55f8 See http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/821 Original issue's description: > Center permission bubble if location bar is hidden in MacOS. > > BUG=440403 > > Committed: https://crrev.com/d24ad3c586bab3c033617c764d47cd55ba71e890 > Cr-Commit-Position: refs/heads/master@{#326575} TBR=groby@chromium.org,felt@chromium.org,hcarmona@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440403 Committed: https://crrev.com/86578ecb7b5ac34212f2a69527809d949a1d6d19 Cr-Commit-Position: refs/heads/master@{#326630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -350 lines) Patch
M chrome/browser/ui/cocoa/base_bubble_controller.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h View 2 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm View 2 chunks +4 lines, -29 lines 0 comments Download
D chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm View 1 chunk +0 lines, -121 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/website_settings/permission_bubble_browser_test_util.h View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/ui/website_settings/permission_bubble_browser_test_util.cc View 1 chunk +0 lines, -101 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Donnelly
Created Revert of Center permission bubble if location bar is hidden in MacOS.
5 years, 8 months ago (2015-04-23 20:28:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092933006/1
5 years, 8 months ago (2015-04-23 20:29:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 20:30:11 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 20:30:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86578ecb7b5ac34212f2a69527809d949a1d6d19
Cr-Commit-Position: refs/heads/master@{#326630}

Powered by Google App Engine
This is Rietveld 408576698