Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1092923006:
Use of base::StringPairs appropriately in cookies (Closed)
|
Created:
5 years, 8 months ago by payal.pandey Modified:
5 years, 8 months ago CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse of base::StringPairs appropriately in cookies
Because base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;
BUG=412250
Committed: https://crrev.com/47e20fdf5de4a38562d0ef2e981134a87c8677d7
Cr-Commit-Position: refs/heads/master@{#326775}
Patch Set 1 #Patch Set 2 : Included the required header file. #
Total comments: 1
Patch Set 3 : Incorporated review comments #Patch Set 4 : Use of base::StringPairs appropriately in cookies #Patch Set 5 : updated for try bot error #Messages
Total messages: 21 (10 generated)
payal.pandey@samsung.com changed reviewers: + eroman@chromium.org
Please have a look, Thanks
payal.pandey@samsung.com changed reviewers: + avi@chromium.org
Included the required header file base/strings/string_split.h Please check & review, Thanks.
lgtm https://codereview.chromium.org/1092923006/diff/20001/net/cookies/cookie_util... File net/cookies/cookie_util_unittest.cc (right): https://codereview.chromium.org/1092923006/diff/20001/net/cookies/cookie_util... net/cookies/cookie_util_unittest.cc:7: #include <vector> can this be removed now?
On 2015/04/23 20:14:39, eroman wrote: > lgtm > > https://codereview.chromium.org/1092923006/diff/20001/net/cookies/cookie_util... > File net/cookies/cookie_util_unittest.cc (right): > > https://codereview.chromium.org/1092923006/diff/20001/net/cookies/cookie_util... > net/cookies/cookie_util_unittest.cc:7: #include <vector> > can this be removed now? Thanks for lgtm.
The CQ bit was checked by payal.pandey@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/1092923006/#ps40001 (title: "Incorporated review comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092923006/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
The CQ bit was checked by payal.pandey@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/1092923006/#ps60001 (title: "Use of base::StringPairs appropriately in cookies")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092923006/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by payal.pandey@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org Link to the patchset: https://codereview.chromium.org/1092923006/#ps80001 (title: "updated for try bot error")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092923006/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/47e20fdf5de4a38562d0ef2e981134a87c8677d7 Cr-Commit-Position: refs/heads/master@{#326775} |
