Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1558)

Unified Diff: test/cctest/test-heap.cc

Issue 1092923002: Remove support for externally backed elements from the API (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/unittests/test-utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index 93540560f3918b7a8e55bcffa9e373121e585d55..60f62d51761f0cc4e9b314c2d36be2f71fe0af6e 100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -5317,7 +5317,7 @@ TEST(WritableVsImmortalRoots) {
}
-static void TestRightTrimFixedTypedArray(v8::ExternalArrayType type,
+static void TestRightTrimFixedTypedArray(i::ExternalArrayType type,
int initial_length,
int elements_to_trim) {
v8::HandleScope scope(CcTest::isolate());
@@ -5353,17 +5353,17 @@ TEST(Regress472513) {
// typed array header smashing with free space filler (crbug/472513).
// 64-bit cases.
- TestRightTrimFixedTypedArray(v8::kExternalUint8Array, 32, 6);
- TestRightTrimFixedTypedArray(v8::kExternalUint8Array, 32 - 7, 6);
- TestRightTrimFixedTypedArray(v8::kExternalUint16Array, 16, 6);
- TestRightTrimFixedTypedArray(v8::kExternalUint16Array, 16 - 3, 6);
- TestRightTrimFixedTypedArray(v8::kExternalUint32Array, 8, 6);
- TestRightTrimFixedTypedArray(v8::kExternalUint32Array, 8 - 1, 6);
+ TestRightTrimFixedTypedArray(i::kExternalUint8Array, 32, 6);
+ TestRightTrimFixedTypedArray(i::kExternalUint8Array, 32 - 7, 6);
+ TestRightTrimFixedTypedArray(i::kExternalUint16Array, 16, 6);
+ TestRightTrimFixedTypedArray(i::kExternalUint16Array, 16 - 3, 6);
+ TestRightTrimFixedTypedArray(i::kExternalUint32Array, 8, 6);
+ TestRightTrimFixedTypedArray(i::kExternalUint32Array, 8 - 1, 6);
// 32-bit cases.
- TestRightTrimFixedTypedArray(v8::kExternalUint8Array, 16, 3);
- TestRightTrimFixedTypedArray(v8::kExternalUint8Array, 16 - 3, 3);
- TestRightTrimFixedTypedArray(v8::kExternalUint16Array, 8, 3);
- TestRightTrimFixedTypedArray(v8::kExternalUint16Array, 8 - 1, 3);
- TestRightTrimFixedTypedArray(v8::kExternalUint32Array, 4, 3);
+ TestRightTrimFixedTypedArray(i::kExternalUint8Array, 16, 3);
+ TestRightTrimFixedTypedArray(i::kExternalUint8Array, 16 - 3, 3);
+ TestRightTrimFixedTypedArray(i::kExternalUint16Array, 8, 3);
+ TestRightTrimFixedTypedArray(i::kExternalUint16Array, 8 - 1, 3);
+ TestRightTrimFixedTypedArray(i::kExternalUint32Array, 4, 3);
}
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/unittests/test-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698