Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 1092923002: Remove support for externally backed elements from the API (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove support for externally backed elements from the API Embedders should use ArrayBuffers instead BUG=v8:3996 LOG=y R=verwaest@chromium.org,dslomov@chromium.org,kbr@chromium.org Committed: https://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef Cr-Commit-Position: refs/heads/master@{#27939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -1189 lines) Patch
M include/v8.h View 2 chunks +0 lines, -50 lines 0 comments Download
M src/api.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/api.cc View 4 chunks +10 lines, -152 lines 0 comments Download
M src/d8.h View 1 chunk +0 lines, -18 lines 0 comments Download
M src/objects.h View 1 chunk +13 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 9 chunks +41 lines, -923 lines 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M test/unittests/test-utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/unittests/test-utils.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 19 (5 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-17 11:19:40 UTC) #1
jochen (gone - plz use gerrit)
ptal depends on https://codereview.chromium.org/1095823002
5 years, 8 months ago (2015-04-17 11:31:31 UTC) #2
Toon Verwaest
lgtm
5 years, 8 months ago (2015-04-17 12:38:57 UTC) #3
Dmitry Lomov (no reviews)
this is probably quite problematic for io.js/node.js
5 years, 8 months ago (2015-04-17 13:58:58 UTC) #4
noordhuis
This completely will completely break io.js and node.js and a great many add-ons. Saying embedders ...
5 years, 8 months ago (2015-04-17 14:07:38 UTC) #5
jochen (gone - plz use gerrit)
On 2015/04/17 at 14:07:38, info wrote: > This completely will completely break io.js and node.js ...
5 years, 8 months ago (2015-04-17 14:29:18 UTC) #6
jochen (gone - plz use gerrit)
We decided to move forward with this. The actual change is that now only types ...
5 years, 8 months ago (2015-04-20 11:12:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092923002/1
5 years, 8 months ago (2015-04-20 11:12:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/5017)
5 years, 8 months ago (2015-04-20 11:54:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092923002/1
5 years, 8 months ago (2015-04-20 12:03:41 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4935)
5 years, 8 months ago (2015-04-20 12:34:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092923002/1
5 years, 8 months ago (2015-04-20 12:35:27 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-20 13:31:43 UTC) #18
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 13:31:56 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53cc6486df3e787898294664c0991f00ce57dcef
Cr-Commit-Position: refs/heads/master@{#27939}

Powered by Google App Engine
This is Rietveld 408576698