[Icons NTP] Refactor large_icon_source to extract the logic shared between desktop and Android to f…

components/favicon_base/fallback_icon_style.h

Index: components/favicon_base/fallback_icon_style.h
diff --git a/components/favicon_base/fallback_icon_style.h b/components/favicon_base/fallback_icon_style.h
index 097636b0ccb522aacb2af8aaa0612dfe70afe53d..857cc147b8609fba59b2114a91bf44ea44bc3faf 100644
--- a/components/favicon_base/fallback_icon_style.h
+++ b/components/favicon_base/fallback_icon_style.h
@@ -5,6 +5,7 @@
 #ifndef COMPONENTS_FAVICON_BASE_FALLBACK_ICON_STYLE_H_
 #define COMPONENTS_FAVICON_BASE_FALLBACK_ICON_STYLE_H_
 
+#include "base/memory/ref_counted_memory.h"
 #include "third_party/skia/include/core/SkColor.h"
 
 namespace favicon_base {
@@ -37,6 +38,12 @@ void MatchFallbackIconTextColorAgainstBackgroundColor(FallbackIconStyle* style);
 // Returns whether |style| values are within bounds.
 bool ValidateFallbackIconStyle(const FallbackIconStyle& style);
 
+// Set |style|'s background color to the dominant color of |bitmap_data|,

[huangs, 2015/04/17 15:30:47]

NIT: The fact that default text is light seems to be implementation detail.
Perhaps:

// Reassign |style|'s |background_color| to the dominant color of |bitmap_data|,
but adjust its luminance to better match existing |text_color|.

[beaudoin, 2015/04/17 20:29:05]

I agree with you, but if the text is dark we should force a minimum luminance,
if it's gray we should have an invalid luminance zone in the middle, etc. I
think it's OK to talk about light text here because the operation only makes
sense for light text. (And generalizing it would be overkill.)

[huangs, 2015/04/17 20:44:04]

Acknowledged.

+// clamping luminance down to a reasonable maximum value so that light text is
+// readable.
+void SetDominantColorAsBackground(
+    const scoped_refptr<base::RefCountedMemory>& bitmap_data,
+    FallbackIconStyle* style);
 }  // namespace favicon_base

[huangs, 2015/04/17 15:30:47]

NIT: Add space?

[beaudoin, 2015/04/17 20:29:05]

Done.

 
 #endif  // COMPONENTS_FAVICON_BASE_FALLBACK_ICON_STYLE_H_