[Icons NTP] Refactor large_icon_source to extract the logic shared between desktop and Android to f…

components/favicon/core/favicon_service.cc

Index: components/favicon/core/favicon_service.cc
diff --git a/components/favicon/core/favicon_service.cc b/components/favicon/core/favicon_service.cc
index 31c704128c517311916dedff7fa3eb3abcde2213..43f9f22f1431a21e9156020db4fbb934c447d40f 100644
--- a/components/favicon/core/favicon_service.cc
+++ b/components/favicon/core/favicon_service.cc
@@ -155,7 +155,7 @@ base::CancelableTaskTracker::TaskId
 FaviconService::GetLargestRawFaviconForPageURL(
     const GURL& page_url,
     const std::vector<int>& icon_types,
-    int minimum_size_in_pixels,
+    int minimum_size_in_pixel,

[huangs, 2015/04/20 19:50:25]

Note that changes in favicon_service.h/cc now reduced to trivial renaming.  I'm
fine with this, but some reviewers might not be.

[beaudoin, 2015/04/21 00:15:39]

Good point. I'll leave that for the next person to edit this. It should probably
be in a CL of its own.

Done.

     const favicon_base::FaviconRawBitmapCallback& callback,
     base::CancelableTaskTracker* tracker) {
   favicon_base::FaviconResultsCallback favicon_results_callback =
@@ -169,7 +169,7 @@ FaviconService::GetLargestRawFaviconForPageURL(
   }
   if (history_service_) {
     return history_service_->GetLargestFaviconForURL(page_url, icon_types,
-        minimum_size_in_pixels, callback, tracker);
+        minimum_size_in_pixel, callback, tracker);
   }
   return RunWithEmptyResultAsync(favicon_results_callback, tracker);
 }