[Icons NTP] Refactor large_icon_source to extract the logic shared between desktop and Android to f…

components/favicon_base/fallback_icon_style.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/favicon_base/fallback_icon_style.h"
 
+#include <algorithm>
+
+#include "ui/gfx/color_analysis.h"
 #include "ui/gfx/color_utils.h"
 
 namespace favicon_base {
 
 namespace {
 
 // Luminance threshold for background color determine whether to use dark or
 // light text color.
-int kDarkTextLuminanceThreshold = 190;
+const int kDarkTextLuminanceThreshold = 190;
+
+// The maximum luminance of the background color to ensure light text is
+// readable.
+const double kMaxBackgroundColorLuminance = 0.67;
 
 // Default values for FallbackIconStyle.
-SkColor kDefaultBackgroundColor = SkColorSetRGB(0x80, 0x80, 0x80);
-SkColor kDefaultTextColorDark = SK_ColorBLACK;
-SkColor kDefaultTextColorLight = SK_ColorWHITE;
-double kDefaultFontSizeRatio = 0.8;
-double kDefaultRoundness = 0.125;  // 1 / 8.
+const SkColor kDarkGray = SkColorSetRGB(0x78, 0x78, 0x78);
+const SkColor kDefaultBackgroundColor = kDarkGray;

[pkotwicz, 2015/04/21 18:19:48]

Nit: Remove separate |kDarkGray| variable. It only has one user.

[beaudoin, 2015/04/21 19:03:23]

Done.

+const SkColor kDefaultTextColorDark = SK_ColorBLACK;
+const SkColor kDefaultTextColorLight = SK_ColorWHITE;
+const double kDefaultFontSizeRatio = 0.44;
+const double kDefaultRoundness = 0;  // Square. Round corners are applied
+                                     // externally (Javascript or Java).
 
 }  // namespace
 
 FallbackIconStyle::FallbackIconStyle()
     : background_color(kDefaultBackgroundColor),
       text_color(kDefaultTextColorLight),
       font_size_ratio(kDefaultFontSizeRatio),
       roundness(kDefaultRoundness) {
 }
 
 FallbackIconStyle::~FallbackIconStyle() {
 }
 
 void MatchFallbackIconTextColorAgainstBackgroundColor(
     FallbackIconStyle* style) {
   int luminance = color_utils::GetLuminanceForColor(style->background_color);
   style->text_color = (luminance >= kDarkTextLuminanceThreshold ?
       kDefaultTextColorDark : kDefaultTextColorLight);
 }
 
 bool ValidateFallbackIconStyle(const FallbackIconStyle& style) {
   return style.font_size_ratio >= 0.0 && style.font_size_ratio <= 1.0 &&
       style.roundness >= 0.0 && style.roundness <= 1.0;
 }
 
+void SetDominantColorAsBackground(
+    const scoped_refptr<base::RefCountedMemory>& bitmap_data,
+    FallbackIconStyle* style) {

[pkotwicz, 2015/04/21 18:19:48]

Aside & for another CL: I wonder whether it would make more sense to adjust the
text color for the dominant background color rather than the background color.

[beaudoin, 2015/04/21 19:03:23]

This was in the UI spec. I personally agree that uniform text color is more
important than precisely matching the dominant color. (Which is just an
approximation to begin with.)

+  SkColor dominant_color =
+      color_utils::CalculateKMeanColorOfPNG(bitmap_data);
+  // Assumes |style.text_color| is light, and clamps luminance down to a
+  // reasonable maximum value so text is readable.
+  color_utils::HSL color_hsl;
+  color_utils::SkColorToHSL(dominant_color, &color_hsl);
+  color_hsl.l = std::min(color_hsl.l, kMaxBackgroundColorLuminance);
+  style->background_color =
+      color_utils::HSLToSkColor(color_hsl, SK_AlphaOPAQUE);
+}
+
+
 }  // namespace favicon_base