Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1092863002: Apply automated fixits for Chrome clang plugin to base_unittests. (Closed)

Created:
5 years, 8 months ago by dcheng
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org, grt+watch_chromium.org, sadrul, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply automated fixits for Chrome clang plugin to base_unittests. Working on trimming down ~26k warnings on the Windows clang build. BUG=467287 Committed: https://crrev.com/fbce126c210689091efcfe670ca5ca6e63b0aab1 Cr-Commit-Position: refs/heads/master@{#325606}

Patch Set 1 #

Patch Set 2 : Fix format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -86 lines) Patch
M base/async_socket_io_handler.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/file_version_info_win.h View 1 chunk +17 lines, -17 lines 0 comments Download
M base/files/file_path_watcher_win.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M base/logging_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M base/message_loop/message_pump_win.h View 1 chunk +1 line, -1 line 0 comments Download
M base/process/kill_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/sync_socket.h View 1 1 chunk +5 lines, -5 lines 0 comments Download
M base/synchronization/condition_variable_win.cc View 1 2 chunks +10 lines, -10 lines 0 comments Download
M base/synchronization/waitable_event_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_reg_util_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_event_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/enum_variant.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/event_trace_consumer_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M base/win/event_trace_controller_unittest.cc View 1 3 chunks +4 lines, -8 lines 0 comments Download
M base/win/iunknown_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/win/iunknown_impl_unittest.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M base/win/object_watcher_unittest.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M base/win/pe_image.h View 1 chunk +1 line, -1 line 0 comments Download
M base/win/registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/win/registry_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/shortcut_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Taking a slightly different approach this time.
5 years, 8 months ago (2015-04-17 02:08:16 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-17 06:13:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092863002/20001
5 years, 8 months ago (2015-04-17 06:28:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-17 07:36:04 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 07:36:51 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fbce126c210689091efcfe670ca5ca6e63b0aab1
Cr-Commit-Position: refs/heads/master@{#325606}

Powered by Google App Engine
This is Rietveld 408576698