GuestView: Decouple extension IPCs from soon-to-be component IPCs

extensions/browser/guest_view/extensions_guest_view_message_filter.h

Index: extensions/browser/guest_view/extensions_guest_view_message_filter.h
diff --git a/extensions/browser/guest_view/guest_view_message_filter.h b/extensions/browser/guest_view/extensions_guest_view_message_filter.h
similarity index 68%
copy from extensions/browser/guest_view/guest_view_message_filter.h
copy to extensions/browser/guest_view/extensions_guest_view_message_filter.h
index 27e0d1b28bb96fc9abc86d94b8f0bef8c478e1ea..59ad96ee0ee07707457bbb47aa9661dc31c4e6b4 100644
--- a/extensions/browser/guest_view/guest_view_message_filter.h
+++ b/extensions/browser/guest_view/extensions_guest_view_message_filter.h
@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MESSAGE_FILTER_H_
-#define EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MESSAGE_FILTER_H_
+#ifndef EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_MESSAGE_FILTER_H_
+#define EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_MESSAGE_FILTER_H_
 
 #include <string>
 
@@ -26,21 +26,21 @@ class Size;
 
 namespace extensions {
 
-// This class filters out incoming GuestView-specific IPC messages from the
-// renderer process. It is created on the UI thread. Messages may be handled on
-// the IO thread or the UI thread.
-class GuestViewMessageFilter : public content::BrowserMessageFilter {
+// This class filters out incoming extensions GuestView-specific IPC messages
+// from thw renderer process. It is created on the UI thread. Messages may be
+// handled on the IO thread or the UI thread.
+class ExtensionsGuestViewMessageFilter : public content::BrowserMessageFilter {
  public:
-  GuestViewMessageFilter(int render_process_id,
-                         content::BrowserContext* context);
+  ExtensionsGuestViewMessageFilter(int render_process_id,
+                                   content::BrowserContext* context);
 
   int render_process_id() const { return render_process_id_; }

[lazyboy, 2015/04/20 23:37:56]

I don't see this getting used.

[Fady Samuel, 2015/04/21 15:59:41]

Removed.

 
  private:
   friend class content::BrowserThread;
-  friend class base::DeleteHelper<GuestViewMessageFilter>;
+  friend class base::DeleteHelper<ExtensionsGuestViewMessageFilter>;
 
-  ~GuestViewMessageFilter() override;
+  ~ExtensionsGuestViewMessageFilter() override;
 
   // content::BrowserMessageFilter implementation.
   void OverrideThreadForMessage(const IPC::Message& message,
@@ -49,9 +49,6 @@ class GuestViewMessageFilter : public content::BrowserMessageFilter {
   bool OnMessageReceived(const IPC::Message& message) override;
 
   // Message handlers on the UI thread.
-  void OnAttachGuest(int element_instance_id,
-                     int guest_instance_id,
-                     const base::DictionaryValue& attach_params);
   void OnCreateMimeHandlerViewGuest(int render_frame_id,

[lazyboy, 2015/04/20 23:37:56]

Sort these msg handlers here and in cpp.

[Fady Samuel, 2015/04/21 15:59:41]

Done.

                                     const std::string& view_id,
                                     int element_instance_id,
@@ -77,11 +74,11 @@ class GuestViewMessageFilter : public content::BrowserMessageFilter {
   content::BrowserContext* const browser_context_;
 
   // Weak pointers produced by this factory are bound to the IO thread.
-  base::WeakPtrFactory<GuestViewMessageFilter> weak_ptr_factory_;
+  base::WeakPtrFactory<ExtensionsGuestViewMessageFilter> weak_ptr_factory_;
 
-  DISALLOW_COPY_AND_ASSIGN(GuestViewMessageFilter);
+  DISALLOW_COPY_AND_ASSIGN(ExtensionsGuestViewMessageFilter);
 };
 
 }  // namespace extensions
 
-#endif  // EXTENSIONS_BROWSER_GUEST_VIEW_GUEST_VIEW_MESSAGE_FILTER_H_
+#endif  // EXTENSIONS_BROWSER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_MESSAGE_FILTER_H_