GuestView: Decouple extension IPCs from soon-to-be component IPCs

GuestView: Decouple extension IPCs from soon-to-be component IPCs

In the feature, GuestViewMessageFilter will move to components and ExtensionsGuestViewMessageFilter will stay in the extensions module.

BUG=444869
TBR=rockot@chromium.org for non-guestview extensions, kenrb@chromium.org for _messages.h These are all just mechanical refactors.

Committed: https://crrev.com/b0dc17d87cb785557687aea9532f60154acac198
Cr-Commit-Position: refs/heads/master@{#326082}

[Fady Samuel, 2015-04-20 21:49:30]

Patchset #2 (id:20001) has been deleted

[Fady Samuel, 2015-04-20 23:20:36]

fsamuel@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2015-04-20 23:37:57]

Add a bit more to the CL description,
the intention of creating ExtensionGVMF, where existing
GuestViewMF would end up, etc.
Thanks.

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/brows...
File extensions/browser/guest_view/extensions_guest_view_message_filter.cc
(right):

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/brows...
extensions/browser/guest_view/extensions_guest_view_message_filter.cc:65:
IPC_MESSAGE_HANDLER(ExtensionsGuestViewHostMsg_CreateMimeHandlerViewGuest,
Sort

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/brows...
File extensions/browser/guest_view/extensions_guest_view_message_filter.h
(right):

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/brows...
extensions/browser/guest_view/extensions_guest_view_message_filter.h:14:
namespace base {
Remove

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/brows...
extensions/browser/guest_view/extensions_guest_view_message_filter.h:37: int
render_process_id() const { return render_process_id_; }
I don't see this getting used.

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/brows...
extensions/browser/guest_view/extensions_guest_view_message_filter.h:52: void
OnCreateMimeHandlerViewGuest(int render_frame_id,
Sort these msg handlers here and in cpp.

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/commo...
File extensions/common/guest_view/extensions_guest_view_messages.h (right):

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/commo...
extensions/common/guest_view/extensions_guest_view_messages.h:10: #include
"base/values.h"
Remove.

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/commo...
File extensions/common/guest_view/guest_view_messages.h (right):

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/commo...
extensions/common/guest_view/guest_view_messages.h:12: #include
"ui/gfx/geometry/size.h"
Clean up the includes here and in other places.

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/rende...
File extensions/renderer/guest_view/guest_view_container.cc (right):

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/rende...
extensions/renderer/guest_view/guest_view_container.cc:53: case
ExtensionsGuestViewMsg_CreateMimeHandlerViewGuestACK::ID:
sort

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/rende...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://chromiumcodereview.appspot.com/1092853002/diff/40001/extensions/rende...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:168:
IPC_MESSAGE_HANDLER(ExtensionsGuestViewMsg_CreateMimeHandlerViewGuestACK,
sort

https://chromiumcodereview.appspot.com/1092853002/diff/40001/ipc/ipc_message_...
File ipc/ipc_message_start.h (right):

https://chromiumcodereview.appspot.com/1092853002/diff/40001/ipc/ipc_message_...
ipc/ipc_message_start.h:125: ExtensionsGuestViewMsgStart,
This doesn't need to come last, right? So put this before GuestViewMsgStart?

[Fady Samuel, 2015-04-21 15:59:42]

PTAL

https://codereview.chromium.org/1092853002/diff/40001/extensions/browser/gues...
File extensions/browser/guest_view/extensions_guest_view_message_filter.cc
(right):

https://codereview.chromium.org/1092853002/diff/40001/extensions/browser/gues...
extensions/browser/guest_view/extensions_guest_view_message_filter.cc:65:
IPC_MESSAGE_HANDLER(ExtensionsGuestViewHostMsg_CreateMimeHandlerViewGuest,
On 2015/04/20 23:37:56, lazyboy wrote:
> Sort

Done.

https://codereview.chromium.org/1092853002/diff/40001/extensions/browser/gues...
File extensions/browser/guest_view/extensions_guest_view_message_filter.h
(right):

https://codereview.chromium.org/1092853002/diff/40001/extensions/browser/gues...
extensions/browser/guest_view/extensions_guest_view_message_filter.h:14:
namespace base {
On 2015/04/20 23:37:56, lazyboy wrote:
> Remove

Done.

https://codereview.chromium.org/1092853002/diff/40001/extensions/browser/gues...
extensions/browser/guest_view/extensions_guest_view_message_filter.h:37: int
render_process_id() const { return render_process_id_; }
On 2015/04/20 23:37:56, lazyboy wrote:
> I don't see this getting used.

Removed.

https://codereview.chromium.org/1092853002/diff/40001/extensions/browser/gues...
extensions/browser/guest_view/extensions_guest_view_message_filter.h:52: void
OnCreateMimeHandlerViewGuest(int render_frame_id,
On 2015/04/20 23:37:56, lazyboy wrote:
> Sort these msg handlers here and in cpp.

Done.

https://codereview.chromium.org/1092853002/diff/40001/extensions/common/guest...
File extensions/common/guest_view/extensions_guest_view_messages.h (right):

https://codereview.chromium.org/1092853002/diff/40001/extensions/common/guest...
extensions/common/guest_view/extensions_guest_view_messages.h:10: #include
"base/values.h"
On 2015/04/20 23:37:56, lazyboy wrote:
> Remove.

Done.

https://codereview.chromium.org/1092853002/diff/40001/extensions/common/guest...
File extensions/common/guest_view/guest_view_messages.h (right):

https://codereview.chromium.org/1092853002/diff/40001/extensions/common/guest...
extensions/common/guest_view/guest_view_messages.h:12: #include
"ui/gfx/geometry/size.h"
On 2015/04/20 23:37:56, lazyboy wrote:
> Clean up the includes here and in other places.

Done.

https://codereview.chromium.org/1092853002/diff/40001/extensions/renderer/gue...
File extensions/renderer/guest_view/guest_view_container.cc (right):

https://codereview.chromium.org/1092853002/diff/40001/extensions/renderer/gue...
extensions/renderer/guest_view/guest_view_container.cc:53: case
ExtensionsGuestViewMsg_CreateMimeHandlerViewGuestACK::ID:
On 2015/04/20 23:37:56, lazyboy wrote:
> sort

Done.

https://codereview.chromium.org/1092853002/diff/40001/extensions/renderer/gue...
File
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
(right):

https://codereview.chromium.org/1092853002/diff/40001/extensions/renderer/gue...
extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc:168:
IPC_MESSAGE_HANDLER(ExtensionsGuestViewMsg_CreateMimeHandlerViewGuestACK,
On 2015/04/20 23:37:56, lazyboy wrote:
> sort

Done.

https://codereview.chromium.org/1092853002/diff/40001/ipc/ipc_message_start.h
File ipc/ipc_message_start.h (right):

https://codereview.chromium.org/1092853002/diff/40001/ipc/ipc_message_start.h...
ipc/ipc_message_start.h:125: ExtensionsGuestViewMsgStart,
On 2015/04/20 23:37:56, lazyboy wrote:
> This doesn't need to come last, right? So put this before GuestViewMsgStart?

Done.

[lazyboy, 2015-04-21 17:32:58]

lgtm

https://chromiumcodereview.appspot.com/1092853002/diff/60001/extensions/commo...
File extensions/common/guest_view/extensions_guest_view_messages.h (right):

https://chromiumcodereview.appspot.com/1092853002/diff/60001/extensions/commo...
extensions/common/guest_view/extensions_guest_view_messages.h:28: // Queries
whether the RenderView of the provided |routing_id| is allowed to
Thanks for adding the description.

[Fady Samuel, 2015-04-21 17:34:30]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-04-21 17:34:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1092853002/60001

[Fady Samuel, 2015-04-21 17:36:57]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2015-04-21 17:38:09]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-04-21 17:39:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1092853002/60001

[commit-bot: I haz the power, 2015-04-21 18:41:47]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-04-21 18:42:55]

Patchset 3 (id:??) landed as
https://crrev.com/b0dc17d87cb785557687aea9532f60154acac198
Cr-Commit-Position: refs/heads/master@{#326082}