Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 1092843003: Revert of Roll Android SDK and AppCompat. (Closed)

Created:
5 years, 8 months ago by azarchs
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll Android SDK and AppCompat. (patchset #2 id:20001 of https://codereview.chromium.org/1101633003/) Reason for revert: Breaks downstream Chrome Android ToT instrumentation test. BUG=480285 Original issue's description: > Roll Android SDK and AppCompat. > > - Android SDK rolls to API 22 rev 2 > (no API changes, just bug fixes) > - Android Support Library rolls to 22.1.0 > > BUG=479858 > > Committed: https://crrev.com/a068236fabb7a1925df7494bd668c2b58b26979a > Cr-Commit-Position: refs/heads/master@{#326437} TBR=newt@chromium.org,cjhopman@chromium.org,aurimas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=479858 Committed: https://crrev.com/dd703b9316d9b346ec1bf6ec357884d40ffe80e6 Cr-Commit-Position: refs/heads/master@{#326484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/process_resources.py View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
azarchs
Created Revert of Roll Android SDK and AppCompat.
5 years, 8 months ago (2015-04-23 09:31:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092843003/1
5 years, 8 months ago (2015-04-23 09:31:37 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-23 09:31:39 UTC) #4
pasko
lgtm
5 years, 8 months ago (2015-04-23 09:34:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092843003/1
5 years, 8 months ago (2015-04-23 09:35:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 09:35:35 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dd703b9316d9b346ec1bf6ec357884d40ffe80e6 Cr-Commit-Position: refs/heads/master@{#326484}
5 years, 8 months ago (2015-04-23 09:36:31 UTC) #10
aurimas (slooooooooow)
5 years, 8 months ago (2015-04-23 18:20:27 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1086523004/ by aurimas@chromium.org.

The reason for reverting is: Downstream needs a fix in styles.xml to roll this
in..

Powered by Google App Engine
This is Rietveld 408576698