Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 10928237: Add support for parsing a 'partition' attribute on the <browser> tag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Resolving conflicts and removing redudnat variable. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index 29f9b6dc55798dafa0286f5266877d4e6bdaa855..2d0cc1d049b93417cffb217ba5b68c08b2aed362 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -35,6 +35,13 @@ class CONTENT_EXPORT BrowserPlugin :
// Set the src attribute value of the BrowserPlugin instance and reset
// the guest_crashed_ flag.
void SetSrcAttribute(const std::string& src);
+ // The partition identifier string is stored as UTF-8.
+ std::string GetPartitionAttribute() const;
+ // This method can be successfully called only before the first navigation for
+ // this instance of BrowserPlugin. If an error occurs, the |error_message| is
+ // set appropriately to indicate the failure reason.
+ bool SetPartitionAttribute(const std::string& partition_id,
+ std::string& error_message);
// Inform the BrowserPlugin to update its backing store with the pixels in
// its damage buffer.
@@ -119,10 +126,9 @@ class CONTENT_EXPORT BrowserPlugin :
// Virtual to allow for mocking in tests.
virtual float GetDeviceScaleFactor() const;
- // Parses the source URL of the browser plugin from the element's attributes
- // and outputs them.
- bool ParseSrcAttribute(const WebKit::WebPluginParams& params,
- std::string* src);
+ // Parses the attributes of the browser plugin from the element's attributes
+ // and sets them appropriately.
+ void ParseAttributes(const WebKit::WebPluginParams& params);
// Cleanup event listener state to free v8 resources when a BrowserPlugin
// is destroyed.
@@ -143,6 +149,8 @@ class CONTENT_EXPORT BrowserPlugin :
bool navigate_src_sent_;
int64 parent_frame_;
std::string src_;
+ std::string storage_partition_id_;
+ bool persist_storage_;
typedef std::vector<v8::Persistent<v8::Function> > EventListeners;
typedef std::map<std::string, EventListeners> EventListenerMap;
EventListenerMap event_listener_map_;
« no previous file with comments | « no previous file | content/renderer/browser_plugin/browser_plugin.cc » ('j') | content/renderer/browser_plugin/browser_plugin.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698