Add support for parsing a 'partition' attribute on the <browser> tag.

content/renderer/browser_plugin/browser_plugin.h

Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index 210774b25f4831e1525a63833aedbed87601209c..9350e00cf46199c6f75cdf3a1baa8fd9dcd87d62 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -32,6 +32,13 @@ class CONTENT_EXPORT BrowserPlugin :
   // Set the src attribute value of the BrowserPlugin instance and reset
   // the guest_crashed_ flag.
   void SetSrcAttribute(const std::string& src);
+  // The partition identifier string is stored as UTF-8.
+  std::string GetPartitionAttribute() const;
+  // This method can successfully called only before the first navigation for

[Charlie Reis, 2012/09/19 00:06:31]

nit: can be

[nasko, 2012/09/19 17:03:23]

Done.

+  // the instance of BrowserPlugin. If an error occurs, the |error_message| is

[Charlie Reis, 2012/09/19 00:06:31]

nit: this instance

Also, we should mention that it can only be set once, if we're sticking with
that restriction.

[nasko, 2012/09/19 17:03:23]

Done.

+  // set appropriately to indicate the failure reason.
+  bool SetPartitionAttribute(const std::string& partition_id,
+                             std::string& error_message);
 
   // Inform the BrowserPlugin to update its backing store with the pixels in
   // its damage buffer.
@@ -116,10 +123,9 @@ class CONTENT_EXPORT BrowserPlugin :
   // Virtual to allow for mocking in tests.
   virtual float GetDeviceScaleFactor() const;
 
-  // Parses the source URL of the browser plugin from the element's attributes
-  // and outputs them.
-  bool ParseSrcAttribute(const WebKit::WebPluginParams& params,
-                         std::string* src);
+  // Parses the attributes of the browser plugin from the element's attributes
+  // and sets them appropriately.
+  void ParseAttributes(const WebKit::WebPluginParams& params);
 
   // Cleanup event listener state to free v8 resources when a BrowserPlugin
   // is destroyed.
@@ -138,6 +144,12 @@ class CONTENT_EXPORT BrowserPlugin :
   bool resize_pending_;
   long long parent_frame_;
   std::string src_;
+  // TODO(nasko): This member could potentially be equivalent to
+  // navigate_src_sent_ from an upcoming CL. Remove it if this is the case once
+  // the new code lands.
+  bool has_navigated_;
+  std::string storage_partition_id_;
+  bool persist_storage_;

[Charlie Reis, 2012/09/19 00:06:31]

Is it worth exposing this separately, so that callers of GetPartitionAttribute
don't have to parse it out again?  Or are you planning to do that later?

[nasko, 2012/09/19 17:03:23]

I'm not sure if we will have internal callers in RV that will use this
information. If we do, I will expose it, but for the time being I'm leaving it
as is. This will be sent separately up to the browser process to determine
storage partition, but it will likely not go through GetPartitionAttribute.

   typedef std::vector<v8::Persistent<v8::Function> > EventListeners;
   typedef std::map<std::string, EventListeners> EventListenerMap;
   EventListenerMap event_listener_map_;