Issue 10928224: views/examples: views_examples_with_content_lib should have its own export.h file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10928224: views/examples: views_examples_with_content_lib should have its own export.h file. (Closed)

Created:
8 years, 3 months ago by tfarina

Modified:
8 years, 3 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

views/examples: views_examples_with_content_lib should have its own export.h file. And its own IMPLEMENTATION macro definition. BUG=141187 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157265

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -4 lines)			Patch
M	ui/views/examples/examples_window_with_content.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A	ui/views/examples/views_examples_with_content_export.h	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	ui/views/views.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

tfarina

In a follow up then I'll make the change to use VIEWS_EXAMPLES_EXPORT in examples_window.h. Please, ...

8 years, 3 months ago (2012-09-17 01:45:33 UTC) #1

lgtm