Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Issue 10928211: Speculative revert did not stablize the tests... see crbug.com/149157 (Closed)

Created:
8 years, 3 months ago by msw
Modified:
8 years, 3 months ago
Reviewers:
satorux1
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Speculative revert did not stablize the tests... see crbug.com/149157 Revert 156865 - Revert 156744 - chromeos: Use EventRouterForwarder to disptch systemPrivate extension events Reason: Seem to be causing ExtensionServiceTest unit_tests timeout on "Linux ChromiumOS Tests (1)". See crbug.com/149157 for details. BUG=148552 TEST=Boot a Chromebook, type the password for a user, start pressing brightness up/down key randomly, press Enter to login while keeping pressing brightness keys, ensure no crash report is sent during login. Review URL: https://chromiumcodereview.appspot.com/10905250 TBR=hashimoto@chromium.org Review URL: https://codereview.chromium.org/10919299 TBR=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M chrome/browser/extensions/system/system_api.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/system/system_api.cc View 2 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
msw
8 years, 3 months ago (2012-09-14 21:58:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698