More Gmail Checker fixes.

More Gmail Checker fixes.

BUG=148774, 148777
TBR=mpcomplete@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156500

[Aaron Boodman, 2012-09-13 04:03:06]

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/examples/extensions/gmail/background.js
(left):

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:18: var
unreadCount = -1;
Moved unreadCount into local storage so that we can correctly detect changes
across event page wakes.

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:94:
function init() {
Because the unreadCount wasn't saved, the updateIcon call here was resetting the
icon to not_logged_in on each startup.

In the case of event pages, we don't need to reset the icon state at startup,
and these variables initializations can be moved to the top of the file.

So just deleted this and called updateIcon in the case of oldVersion.

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:278:
document.addEventListener('DOMContentLoaded', init);
See note at init().

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/examples/extensions/gmail/background.js
(right):

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:10: var
canvas = document.getElementById('canvas');
See note for init().

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:27: url +=
localStorage.customDomain.replace(/^\/?(.*?)\/?$/, '$1') + '/';
I'll remove this in a new patchset.

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:185: var
result = xmlDoc.evaluate("/gmail:feed/gmail:link/@href",
This handles the case where mail.google.com/mail/ is redirected to /mail/u/0/.
We detect the redirect this way and learn the correct Gmail URL. This allows
isGmailUrl to work properly.

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:280:
function onAlarm() {
Just moved from below.

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:285:
updateIcon();
See note at init().

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/examples/extensions/gmail/manifest.json
(right):

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/manifest.json:22:
"version": "4.3.2",
I uploaded a .1 yesterday, but forgot to commit :\.

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/examples/extensions/gmail/options.js (right):

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/options.js:28:
customDomainsTextbox.value.replace(/^\/?(.*?)\/?$/, '$1');
Strip leading and trailing slashes, as that's an easy mistake for users to make.

[Aaron Boodman, 2012-09-13 05:00:26]

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/examples/extensions/gmail/background.js
(right):

https://codereview.chromium.org/10928174/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:185: var
result = xmlDoc.evaluate("/gmail:feed/gmail:link/@href",
On 2012/09/13 04:03:06, Aaron Boodman wrote:
> This handles the case where mail.google.com/mail/ is redirected to /mail/u/0/.
> We detect the redirect this way and learn the correct Gmail URL. This allows
> isGmailUrl to work properly.

Nevermind, tested on a non-multilogin gmail account, did not work. Put back the
way it was.

Main outcome of this is that some minor UI things don't work right on
multilogin, but that was already the case.

[Matt Perry, 2012-09-13 23:20:10]

lgtm