Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 10928160: Limit the maximum number of formal parameters (32K fixed and 32K optional) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object_snapshot.cc
===================================================================
--- runtime/vm/raw_object_snapshot.cc (revision 12287)
+++ runtime/vm/raw_object_snapshot.cc (working copy)
@@ -484,10 +484,9 @@
// Set all the non object fields.
func.set_token_pos(reader->ReadIntptrValue());
func.set_end_token_pos(reader->ReadIntptrValue());
- func.set_num_fixed_parameters(reader->ReadIntptrValue());
- func.set_num_optional_positional_parameters(reader->ReadIntptrValue());
- func.set_num_optional_named_parameters(reader->ReadIntptrValue());
func.set_usage_counter(reader->ReadIntptrValue());
+ func.set_num_fixed_parameters(reader->ReadIntptrValue());
+ func.set_num_optional_parameters(reader->ReadIntptrValue());
func.set_deoptimization_counter(reader->ReadIntptrValue());
func.set_kind_tag(reader->ReadIntptrValue());
@@ -520,10 +519,9 @@
// Write out all the non object fields.
writer->WriteIntptrValue(ptr()->token_pos_);
writer->WriteIntptrValue(ptr()->end_token_pos_);
- writer->WriteIntptrValue(ptr()->num_fixed_parameters_);
- writer->WriteIntptrValue(ptr()->num_optional_positional_parameters_);
- writer->WriteIntptrValue(ptr()->num_optional_named_parameters_);
writer->WriteIntptrValue(ptr()->usage_counter_);
+ writer->WriteIntptrValue(ptr()->num_fixed_parameters_);
+ writer->WriteIntptrValue(ptr()->num_optional_parameters_);
writer->WriteIntptrValue(ptr()->deoptimization_counter_);
writer->WriteIntptrValue(ptr()->kind_tag_);
« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698