runtime/vm/flow_graph_compiler_ia32.cc - Issue 10928160: Limit the maximum number of formal parameters (32K fixed and 32K optional)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 10928160: Limit the maximum number of formal parameters (32K fixed and 32K optional) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

===================================================================

--- runtime/vm/flow_graph_compiler_ia32.cc (revision 12287)

+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)

@@ -621,8 +621,8 @@

function.is_native() && function.IsImplicitInstanceClosureFunction();

LocalScope* scope = parsed_function().node_sequence()->scope();

const int num_fixed_params = function.num_fixed_parameters();

- const int num_opt_pos_params = function.num_optional_positional_parameters();

- int num_opt_named_params = function.num_optional_named_parameters();

+ const int num_opt_pos_params = function.NumOptionalPositionalParameters();

+ int num_opt_named_params = function.NumOptionalNamedParameters();

const int num_params =

num_fixed_params + num_opt_pos_params + num_opt_named_params;

int implicit_this_param_pos = is_native_instance_closure ? -1 : 0;

« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »