Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 10928160: Limit the maximum number of formal parameters (32K fixed and 32K optional) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 12287)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -2837,11 +2837,10 @@
// We hide implicit parameters, such as a method's receiver. This is
// consistent with Invoke or New, which don't expect their callers to
// provide them in the argument lists they are handed.
- *fixed_param_count = (func.num_fixed_parameters() -
- func.NumberOfImplicitParameters());
+ *fixed_param_count = func.num_fixed_parameters() -
+ func.NumImplicitParameters();
// TODO(regis): Separately report named and positional optional param counts.
- *opt_param_count = (func.num_optional_positional_parameters() +
- func.num_optional_named_parameters());
+ *opt_param_count = func.NumOptionalParameters();
ASSERT(*fixed_param_count >= 0);
ASSERT(*opt_param_count >= 0);
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698