runtime/vm/code_generator_test.cc - Issue 10928160: Limit the maximum number of formal parameters (32K fixed and 32K optional)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator_test.cc

Issue 10928160: Limit the maximum number of formal parameters (32K fixed and 32K optional) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_generator_test.cc

===================================================================

--- runtime/vm/code_generator_test.cc (revision 12287)

+++ runtime/vm/code_generator_test.cc (working copy)

@@ -216,7 +216,8 @@

default_values.SetAt(0, Smi::ZoneHandle(Smi::New(1))); // b = 1.

test->set_default_parameter_values(default_values);

const Function& function = test->function();

- function.SetNumberOfParameters(num_fixed_params, num_opt_params, true);

+ function.set_num_fixed_parameters(num_fixed_params);

+ function.SetNumOptionalParameters(num_opt_params, true);

const bool has_opt_params = true;

const String& native_name =

String::ZoneHandle(Symbols::New("TestSmiSub"));

@@ -386,7 +387,8 @@

default_values.SetAt(2, Smi::ZoneHandle(Smi::New(-32)));

test->set_default_parameter_values(default_values);

const Function& function = test->function();

- function.SetNumberOfParameters(num_fixed_params, num_opt_params, true);

+ function.set_num_fixed_parameters(num_fixed_params);

+ function.SetNumOptionalParameters(num_opt_params, true);

function.set_parameter_types(Array::Handle(Array::New(num_params)));

function.set_parameter_names(Array::Handle(Array::New(num_params)));

const Type& param_type = Type::Handle(Type::DynamicType());

« no previous file with comments | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/compiler.cc » ('j') | no next file with comments »