Media Related changes for TabCapture API

content/public/common/media_stream_request.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_MEDIA_STREAM_REQUEST_H_
 #define CONTENT_PUBLIC_COMMON_MEDIA_STREAM_REQUEST_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 44 matching lines @@
   std::string name;
 };
 
 typedef std::vector<MediaStreamDevice> MediaStreamDevices;
 
 typedef std::map<MediaStreamDeviceType, MediaStreamDevices>
     MediaStreamDeviceMap;
 
 // Represents a request for media streams (audio/video).
 struct CONTENT_EXPORT MediaStreamRequest {
+
+  enum RequestState {

[jam, 2012/10/12 17:21:41]

why is the enum in this struct, it's not used in it?

this seems like it should be in its own file, i.e.
content/public/browser/media_request_state.h. the values should be
REQUEST_STATE_foo

[justinlin, 2012/10/12 20:04:20]

Done. Sounds good to me.

+    STATE_NOT_REQUESTED = 0,
+    STATE_REQUESTED,
+    STATE_PENDING_APPROVAL,
+    STATE_OPENING,
+    STATE_DONE,
+    STATE_CLOSING,
+    STATE_ERROR
+  };
+
   MediaStreamRequest(
       int render_process_id,
       int render_view_id,
       const GURL& security_origin);
 
   ~MediaStreamRequest();
 
   // The render process id generating this request.
   int render_process_id;
 
   // The render view id generating this request.
   int render_view_id;
 
   // The WebKit security origin for the current request (e.g. "html5rocks.com").
   GURL security_origin;
 
   // A list of devices present on the user's computer, for each device type
   // requested.
   // All the elements in this map will be deleted in ~MediaStreamRequest().
   MediaStreamDeviceMap devices;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_MEDIA_STREAM_REQUEST_H_