Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py

Issue 1092803002: telemetry: Remove gaps between interactions when calculating smoothness metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unittest. Change new method to static. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py
diff --git a/tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py b/tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py
index 603af25a822965485779c06fb254f6036a385c1c..13e3ffdc86dd527dd37e86b0dd3fe6b6e2748c12 100644
--- a/tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py
+++ b/tools/telemetry/telemetry/web_perf/metrics/smoothness_unittest.py
@@ -57,17 +57,29 @@ class SmoothnessMetricUnitTest(unittest.TestCase):
self.not_enough_frames_timestamps)
self.assertFalse(has_enough_frames)
- def testComputeSurfaceFlingerMetric(self):
+ def testComputeSurfaceFlingerMetricNoJank(self):
stats = _MockRenderingStats(refresh_period=10,
- frame_timestamps=self.good_timestamps,
- frame_times=[[10, 20], [30, 40, 50]])
+ frame_timestamps=[[10, 20], [130, 140, 150]],
+ frame_times=[[10], [10, 10]])
mithro-old 2015/04/21 03:45:58 I can't see anything in _ComputeSurfaceFlingerMetr
vmiura 2015/04/21 22:04:46 Nothing uses them. This change is just in the int
avg_surface_fps, jank_count, max_frame_delay, frame_lengths = (
self.metric._ComputeSurfaceFlingerMetric(self.page, stats))
- self.assertEquals([1, 1, 1, 1], frame_lengths.values)
+ self.assertEquals([1, 1, 1], frame_lengths.values)
self.assertEquals(1, max_frame_delay.value)
self.assertEquals(0, jank_count.value)
self.assertEquals(100, avg_surface_fps.value)
+ def testComputeSurfaceFlingerMetricJank(self):
+ stats = _MockRenderingStats(
+ refresh_period=10,
+ frame_timestamps=[[10, 20, 50], [130, 140, 150, 170, 180]],
+ frame_times=[[10, 30], [10, 10, 20, 10]])
+ avg_surface_fps, jank_count, max_frame_delay, frame_lengths = (
+ self.metric._ComputeSurfaceFlingerMetric(self.page, stats))
+ self.assertEquals([1, 3, 1, 1, 2, 1], frame_lengths.values)
+ self.assertEquals(3, max_frame_delay.value)
+ self.assertEquals(2, jank_count.value)
+ self.assertEquals(67, avg_surface_fps.value)
+
def testComputeFrameTimeMetricWithNotEnoughFrames(self):
stats = _MockRenderingStats(
refresh_period=10,

Powered by Google App Engine
This is Rietveld 408576698