mojo/public/tools/bindings/generators/mojom_dart_generator.py - Issue 1092793005: Dart: Put generated .mojom.dart files under mojoms pacakge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_dart_generator.py

Issue 1092793005: Dart: Put generated .mojom.dart files under mojoms pacakge. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Merge Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/generators/mojom_dart_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_dart_generator.py b/mojo/public/tools/bindings/generators/mojom_dart_generator.py

index 7ff074e795757632e0d45ed4b318b942544c27b1..ac27fa1d3dde84a5e6a403d43350f0ca40d31172 100644

--- a/mojo/public/tools/bindings/generators/mojom_dart_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_dart_generator.py

@@ -360,7 +360,7 @@ def IsPointerArrayKind(kind):

def GetImportUri(module):

elements = module.namespace.split('.')

elements.append("%s" % module.name)

- return os.path.join(*elements)

+ return os.path.join("mojom", *elements)

class Generator(generator.Generator):

@@ -402,7 +402,7 @@ class Generator(generator.Generator):

def GenerateFiles(self, args):

elements = self.module.namespace.split('.')

elements.append("%s.dart" % self.module.name)

- path = os.path.join("dart-gen", *elements)

+ path = os.path.join("dart-gen", "mojom", *elements)

self.Write(self.GenerateLibModule(args), path)

link = self.MatchMojomFilePath("%s.dart" % self.module.name)

if os.path.exists(os.path.join(self.output_dir, link)):

« no previous file with comments | « mojo/public/dart/application.dart ('k') | services/dart/dart_apptests/echo_apptests.dart » ('j') | no next file with comments »