Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1092793002: Add PS 'all' weight name to scanFont. (Closed)

Created:
5 years, 8 months ago by bungeman-skia
Modified:
5 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add PS 'all' weight name to scanFont. Multiple Master fonts often list their weight as 'all'. However, they usually default to normal weight. State explicitly that we know about this weight string. Committed: https://skia.googlesource.com/skia/+/d803cdad725b6db07b6df0ae7f390f5dbef46475

Patch Set 1 #

Patch Set 2 : Make comment more specific. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092793002/20001
5 years, 8 months ago (2015-04-16 21:05:06 UTC) #2
bungeman-skia
This doesn't change any actual current behavior, since the weight will default to 'normal'. However, ...
5 years, 8 months ago (2015-04-16 21:07:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-16 21:11:51 UTC) #6
mtklein
lgtm
5 years, 8 months ago (2015-04-16 21:19:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092793002/20001
5 years, 8 months ago (2015-04-16 21:22:39 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 21:22:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d803cdad725b6db07b6df0ae7f390f5dbef46475

Powered by Google App Engine
This is Rietveld 408576698