Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1092783002: Revert of Revert "Remove early bail-out in VisitWeakList to investigate chrasher." (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert "Remove early bail-out in VisitWeakList to investigate chrasher." (patchset #1 id:1 of https://codereview.chromium.org/1080303002/) Reason for revert: Still doesn't work Original issue's description: > Revert "Remove early bail-out in VisitWeakList to investigate chrasher." > > > BUG=468601 > > LOG=n > > > > Review URL: https://codereview.chromium.org/1016353002 > > > > Cr-Commit-Position: refs/heads/master@{#27317} > > R=hpayer@chromium.org > BUG=v8:3996, chromium:468601 > LOG=n > > Committed: https://crrev.com/835eeafe32f442d7b43fe175237de2c70ed7ceef > Cr-Commit-Position: refs/heads/master@{#27814} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996, chromium:468601 Committed: https://crrev.com/fd7d881e2be920cb1c020a5663bad400833770ee Cr-Commit-Position: refs/heads/master@{#27902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M src/heap/objects-visiting.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Revert "Remove early bail-out in VisitWeakList to investigate chrasher."
5 years, 8 months ago (2015-04-16 20:59:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092783002/1
5 years, 8 months ago (2015-04-16 21:00:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 21:00:18 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 21:00:29 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd7d881e2be920cb1c020a5663bad400833770ee
Cr-Commit-Position: refs/heads/master@{#27902}

Powered by Google App Engine
This is Rietveld 408576698