Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 109273003: Make arguments to insertAdjacentHTML method non-optional (Closed)

Created:
7 years ago by davve
Modified:
7 years ago
Reviewers:
Mike West, eseidel
CC:
blink-reviews, watchdog-blink-watchlist_google.com, dglazkov+blink, arv+blink, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make arguments to insertAdjacentHTML method non-optional http://domparsing.spec.whatwg.org/#dom-element-insertadjacenthtml Both Firefox and IE throws when either argument is missing. BUG=326970 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163519

Patch Set 1 #

Patch Set 2 : Correct base. Should not include https://codereview.chromium.org/110383002/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M LayoutTests/fast/dynamic/insertAdjacentHTML.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/dynamic/insertAdjacentHTML-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davve
7 years ago (2013-12-09 16:06:02 UTC) #1
Mike West
Hi David, thanks for this patch. The change LGTM, but please let the linux_chromeos bot ...
7 years ago (2013-12-09 19:36:26 UTC) #2
davve
> .. but please let the linux_chromeos bot run through before > landing the patch. ...
7 years ago (2013-12-09 19:56:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/109273003/20001
7 years ago (2013-12-10 07:56:39 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-10 09:06:45 UTC) #5
Message was sent while issue was closed.
Change committed as 163519

Powered by Google App Engine
This is Rietveld 408576698