chrome/renderer/spellchecker/hunspell_engine.cc - Issue 109273002: Convert base::MemoryMappedFile to use File instead of PlatformFile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/spellchecker/hunspell_engine.cc

Issue 109273002: Convert base::MemoryMappedFile to use File instead of PlatformFile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Posix GetSize Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/spellchecker/hunspell_engine.cc

diff --git a/chrome/renderer/spellchecker/hunspell_engine.cc b/chrome/renderer/spellchecker/hunspell_engine.cc

index 74dd292fb1585046871656324c7079c0737eae32..c2cdd29f560f2567965120a686c6fe39cb09900e 100644

--- a/chrome/renderer/spellchecker/hunspell_engine.cc

+++ b/chrome/renderer/spellchecker/hunspell_engine.cc

@@ -61,7 +61,9 @@ void HunspellEngine::InitializeHunspell() {

bdict_file_.reset(new base::MemoryMappedFile);

- if (bdict_file_->Initialize(file_)) {

+ // TODO(rvargas): This object should not keep file_ after passing it to

+ // bdict_file_.

+ if (bdict_file_->Initialize(base::File(file_))) {

TimeTicks debug_start_time = base::Histogram::DebugNow();

hunspell_.reset(