Convert base::MemoryMappedFile to use File instead of PlatformFile.

chrome/app/chrome_main_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/chrome_main_delegate.h"
 
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/files/file_path.h"
 #include "base/i18n/rtl.h"
@@ skipping 649 matching lines @@
     // this value could be passed in a different way.
     const std::string locale =
         command_line.GetSwitchValueASCII(switches::kLang);
 #if defined(OS_ANDROID)
     // The renderer sandbox prevents us from accessing our .pak files directly.
     // Therefore file descriptors to the .pak files that we need are passed in
     // at process creation time.
     int locale_pak_fd = base::GlobalDescriptors::GetInstance()->MaybeGet(
         kAndroidLocalePakDescriptor);
     CHECK(locale_pak_fd != -1);
-    ResourceBundle::InitSharedInstanceWithPakFile(locale_pak_fd, false);
+    ResourceBundle::InitSharedInstanceWithPakFile(base::File(locale_pak_fd),
+                                                  false);

[cpu_(ooo_6.6-7.5), 2013/12/21 23:06:28]

so locale_pak_fd will be closed at this point since the temporary File object of
line 670 went out of scope. Is that ok?

[rvargas (doing something else), 2013/12/27 23:54:39]

The file is effectively passed to ResourceBundle, and from there to DataPack who
uses it to initialize a MemoryMappedFile (it will not be closed when this line
goes out of scope).

What I have to verify with someone familiar with this code is that
base::GlobalDescriptors::GetInstance()->MaybeGet is OK with the file being
closed by someone else (it would be better to return File(s) instead)... but
this particular change is not modifying that behavior.

[rvargas (doing something else), 2013/12/28 02:30:37]

Filed bug 330930, because GlobalDescriptors doesn't consider that case.

 
     int extra_pak_keys[] = {
       kAndroidChrome100PercentPakDescriptor,
       kAndroidUIResourcesPakDescriptor,
     };
     for (size_t i = 0; i < arraysize(extra_pak_keys); ++i) {
       int pak_fd =
           base::GlobalDescriptors::GetInstance()->MaybeGet(extra_pak_keys[i]);
       CHECK(pak_fd != -1);
       ResourceBundle::GetSharedInstance().AddDataPackFromFile(
-          pak_fd, ui::SCALE_FACTOR_100P);
+          base::File(pak_fd), ui::SCALE_FACTOR_100P);
     }
 
     base::i18n::SetICUDefaultLocale(locale);
     const std::string loaded_locale = locale;
 #else
     const std::string loaded_locale =
         ResourceBundle::InitSharedInstanceWithLocale(locale, NULL);
 
     base::FilePath resources_pack_path;
     PathService::Get(chrome::FILE_RESOURCES_PACK, &resources_pack_path);
@@ skipping 164 matching lines @@
 }
 
 content::ContentUtilityClient*
 ChromeMainDelegate::CreateContentUtilityClient() {
 #if defined(CHROME_MULTIPLE_DLL_BROWSER)
   return NULL;
 #else
   return &g_chrome_content_utility_client.Get();
 #endif
 }