Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Side by Side Diff: ui/base/resource/data_pack_unittest.cc

Issue 109273002: Convert base::MemoryMappedFile to use File instead of PlatformFile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Posix GetSize Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_util.h" 5 #include "base/file_util.h"
6 #include "base/files/file.h"
6 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
7 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
8 #include "base/path_service.h" 9 #include "base/path_service.h"
9 #include "base/strings/string_piece.h" 10 #include "base/strings/string_piece.h"
10 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
11 #include "ui/base/resource/data_pack.h" 12 #include "ui/base/resource/data_pack.h"
12 13
13 namespace ui { 14 namespace ui {
14 15
15 class DataPackTest 16 class DataPackTest
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 56
56 TEST(DataPackTest, LoadFromFile) { 57 TEST(DataPackTest, LoadFromFile) {
57 base::ScopedTempDir dir; 58 base::ScopedTempDir dir;
58 ASSERT_TRUE(dir.CreateUniqueTempDir()); 59 ASSERT_TRUE(dir.CreateUniqueTempDir());
59 base::FilePath data_path = dir.path().Append(FILE_PATH_LITERAL("sample.pak")); 60 base::FilePath data_path = dir.path().Append(FILE_PATH_LITERAL("sample.pak"));
60 61
61 // Dump contents into the pak file. 62 // Dump contents into the pak file.
62 ASSERT_EQ(file_util::WriteFile(data_path, kSamplePakContents, kSamplePakSize), 63 ASSERT_EQ(file_util::WriteFile(data_path, kSamplePakContents, kSamplePakSize),
63 static_cast<int>(kSamplePakSize)); 64 static_cast<int>(kSamplePakSize));
64 65
65 bool created = false; 66 base::File file(data_path, base::File::FLAG_OPEN | base::File::FLAG_READ);
66 base::PlatformFileError error_code = base::PLATFORM_FILE_OK; 67 ASSERT_TRUE(file.IsValid());
67 base::PlatformFile file = base::CreatePlatformFile(
68 data_path, base::PLATFORM_FILE_OPEN | base::PLATFORM_FILE_READ,
69 &created, &error_code);
70 68
71 // Load the file through the data pack API. 69 // Load the file through the data pack API.
72 DataPack pack(SCALE_FACTOR_100P); 70 DataPack pack(SCALE_FACTOR_100P);
73 ASSERT_TRUE(pack.LoadFromFile(file)); 71 ASSERT_TRUE(pack.LoadFromFile(file.Pass()));
74 72
75 base::StringPiece data; 73 base::StringPiece data;
76 ASSERT_TRUE(pack.HasResource(4)); 74 ASSERT_TRUE(pack.HasResource(4));
77 ASSERT_TRUE(pack.GetStringPiece(4, &data)); 75 ASSERT_TRUE(pack.GetStringPiece(4, &data));
78 EXPECT_EQ("this is id 4", data); 76 EXPECT_EQ("this is id 4", data);
79 ASSERT_TRUE(pack.HasResource(6)); 77 ASSERT_TRUE(pack.HasResource(6));
80 ASSERT_TRUE(pack.GetStringPiece(6, &data)); 78 ASSERT_TRUE(pack.GetStringPiece(6, &data));
81 EXPECT_EQ("this is id 6", data); 79 EXPECT_EQ("this is id 6", data);
82 80
83 // Try reading zero-length data blobs, just in case. 81 // Try reading zero-length data blobs, just in case.
84 ASSERT_TRUE(pack.GetStringPiece(1, &data)); 82 ASSERT_TRUE(pack.GetStringPiece(1, &data));
85 EXPECT_EQ(0U, data.length()); 83 EXPECT_EQ(0U, data.length());
86 ASSERT_TRUE(pack.GetStringPiece(10, &data)); 84 ASSERT_TRUE(pack.GetStringPiece(10, &data));
87 EXPECT_EQ(0U, data.length()); 85 EXPECT_EQ(0U, data.length());
88 86
89 // Try looking up an invalid key. 87 // Try looking up an invalid key.
90 ASSERT_FALSE(pack.HasResource(140)); 88 ASSERT_FALSE(pack.HasResource(140));
91 ASSERT_FALSE(pack.GetStringPiece(140, &data)); 89 ASSERT_FALSE(pack.GetStringPiece(140, &data));
92
93 base::ClosePlatformFile(file);
94 } 90 }
95 91
96 INSTANTIATE_TEST_CASE_P(WriteBINARY, DataPackTest, ::testing::Values( 92 INSTANTIATE_TEST_CASE_P(WriteBINARY, DataPackTest, ::testing::Values(
97 DataPack::BINARY)); 93 DataPack::BINARY));
98 INSTANTIATE_TEST_CASE_P(WriteUTF8, DataPackTest, ::testing::Values( 94 INSTANTIATE_TEST_CASE_P(WriteUTF8, DataPackTest, ::testing::Values(
99 DataPack::UTF8)); 95 DataPack::UTF8));
100 INSTANTIATE_TEST_CASE_P(WriteUTF16, DataPackTest, ::testing::Values( 96 INSTANTIATE_TEST_CASE_P(WriteUTF16, DataPackTest, ::testing::Values(
101 DataPack::UTF16)); 97 DataPack::UTF16));
102 98
103 TEST(DataPackTest, LoadFileWithTruncatedHeader) { 99 TEST(DataPackTest, LoadFileWithTruncatedHeader) {
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 EXPECT_EQ(two, data); 137 EXPECT_EQ(two, data);
142 ASSERT_TRUE(pack.GetStringPiece(3, &data)); 138 ASSERT_TRUE(pack.GetStringPiece(3, &data));
143 EXPECT_EQ(three, data); 139 EXPECT_EQ(three, data);
144 ASSERT_TRUE(pack.GetStringPiece(4, &data)); 140 ASSERT_TRUE(pack.GetStringPiece(4, &data));
145 EXPECT_EQ(four, data); 141 EXPECT_EQ(four, data);
146 ASSERT_TRUE(pack.GetStringPiece(15, &data)); 142 ASSERT_TRUE(pack.GetStringPiece(15, &data));
147 EXPECT_EQ(fifteen, data); 143 EXPECT_EQ(fifteen, data);
148 } 144 }
149 145
150 } // namespace ui 146 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698