build/android/pylib/constants/keycode.py - Issue 1092703002: [Android] More old_interface conversions in build/android/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/constants/keycode.py

Issue 1092703002: [Android] More old_interface conversions in build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 """Android KeyEvent constants.

	6

	7 http://developer.android.com/reference/android/view/KeyEvent.html

	8 """

	9

	10 BACK = 4
	perezju 2015/04/17 09:16:43 To better mirror the Android SDK, which uses e.g. To better mirror the Android SDK, which uses e.g. KeyEvent.KEYCODE_MENU in Java, we should perhaps name this file "keyevent" and keep the KEYCODE_ prefix on the constant names. It seems a bit redundant, but will be better if at some point we also need to add some of the META_ or other related KeyEvent constants. Also there are lots of constants, we probably don't need to have all of them, but we might also want to start with a few more than just 4. Not sure what should be the criteria for inclusion, though. jbudorick 2015/04/17 13:32:24 sgtm Show quoted text On 2015/04/17 09:16:43, perezju wrote: > To better mirror the Android SDK, which uses e.g. KeyEvent.KEYCODE_MENU in Java, > we should perhaps name this file "keyevent" and keep the KEYCODE_ prefix on the > constant names. sgtm Show quoted text > > It seems a bit redundant, but will be better if at some point we also need to > add some of the META_ or other related KeyEvent constants. > > Also there are lots of constants, we probably don't need to have all of them, > but we might also want to start with a few more than just 4. Not sure what > should be the criteria for inclusion, though. Currently, the criterion is "are they used?" (BACK and MENU are used downstream.) I'm not really keen on adding things we aren't using, and I"m not opposed to adding things as we start using them.
	11 DPAD_RIGHT = 22

	12 ENTER = 66

	13 MENU = 82

	14

OLD	NEW

« build/android/gyp/util/build_device.py ('K') | « build/android/pylib/constants/__init__.py ('k') | build/android/pylib/forwarder.py » ('j') | no next file with comments »