Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1092683004: Manually remove all existing occurences of PrefRegistrySyncable::UNSYNCABLE_PREF (Closed)

Created:
5 years, 7 months ago by raymes
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, markusheintz_, pam+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@prefs-add-reg-funcs1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manually remove all existing occurences of PrefRegistrySyncable::UNSYNCABLE_PREF Now that we have added PrefRegistry registration functions that do not need to accept a flags argument, passing PrefRegistrySyncable::UNSYNCABLE_PREF is redundant and we can remove it altogether. BUG=476800 Committed: https://crrev.com/a40ea6cba96b8d14a715bc1c45a8c8a77724ca94 Cr-Commit-Position: refs/heads/master@{#327439}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : y #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -55 lines) Patch
M chrome/browser/extensions/api/copresence/copresence_api.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/invalidation/profile_invalidation_provider_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/supervised_user/legacy/supervised_user_sync_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/content_settings/core/browser/content_settings_default_provider.cc View 1 2 3 4 2 chunks +7 lines, -6 lines 0 comments Download
M components/content_settings/core/browser/content_settings_pref_provider.cc View 1 2 3 4 2 chunks +7 lines, -6 lines 0 comments Download
M components/pref_registry/pref_registry_syncable.h View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 1 1 chunk +8 lines, -28 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
raymes
5 years, 7 months ago (2015-04-27 01:58:21 UTC) #2
Mattias Nissler (ping if slow)
LGTM https://codereview.chromium.org/1092683004/diff/1/extensions/browser/extension_prefs.cc File extensions/browser/extension_prefs.cc (right): https://codereview.chromium.org/1092683004/diff/1/extensions/browser/extension_prefs.cc#newcode1921 extensions/browser/extension_prefs.cc:1921: true); // default value Should this be indented ...
5 years, 7 months ago (2015-04-27 07:39:00 UTC) #3
raymes
Thanks! +brettw for top level OWNERS https://codereview.chromium.org/1092683004/diff/1/extensions/browser/extension_prefs.cc File extensions/browser/extension_prefs.cc (right): https://codereview.chromium.org/1092683004/diff/1/extensions/browser/extension_prefs.cc#newcode1921 extensions/browser/extension_prefs.cc:1921: true); // default ...
5 years, 7 months ago (2015-04-28 01:31:21 UTC) #5
brettw
owners rubberstamp lgtm
5 years, 7 months ago (2015-04-28 21:33:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092683004/20001
5 years, 7 months ago (2015-04-29 00:03:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/66574)
5 years, 7 months ago (2015-04-29 00:12:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092683004/40001
5 years, 7 months ago (2015-04-29 00:49:58 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/62028)
5 years, 7 months ago (2015-04-29 01:00:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092683004/60001
5 years, 7 months ago (2015-04-29 01:08:20 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/17309)
5 years, 7 months ago (2015-04-29 01:33:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092683004/80001
5 years, 7 months ago (2015-04-29 01:47:56 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-04-29 05:59:31 UTC) #25
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 06:00:27 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a40ea6cba96b8d14a715bc1c45a8c8a77724ca94
Cr-Commit-Position: refs/heads/master@{#327439}

Powered by Google App Engine
This is Rietveld 408576698