Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1092673002: Move FilterEffectRenderer to core/paint/ (Closed)

Created:
5 years, 8 months ago by fs
Modified:
5 years, 8 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, Dominik Röttsches, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move FilterEffectRenderer to core/paint/ Also some minor include cleanups. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193956

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rename to FilterEffectBuilder. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -390 lines) Patch
M Source/core/core.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/layout/FilterEffectRenderer.h View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/core/layout/FilterEffectRenderer.cpp View 1 chunk +0 lines, -262 lines 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 1 2 6 chunks +12 lines, -14 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerFilterInfo.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerFilterInfo.cpp View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerPainter.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A + Source/core/paint/FilterEffectBuilder.h View 1 4 chunks +9 lines, -9 lines 0 comments Download
A + Source/core/paint/FilterEffectBuilder.cpp View 1 3 chunks +6 lines, -14 lines 0 comments Download
M Source/core/paint/FilterPainter.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
fs
5 years, 8 months ago (2015-04-16 14:54:58 UTC) #2
chrishtr
https://codereview.chromium.org/1092673002/diff/1/Source/core/paint/FilterEffectRenderer.h File Source/core/paint/FilterEffectRenderer.h (right): https://codereview.chromium.org/1092673002/diff/1/Source/core/paint/FilterEffectRenderer.h#newcode42 Source/core/paint/FilterEffectRenderer.h:42: class FilterEffectRenderer final : public RefCountedWillBeGarbageCollectedFinalized<FilterEffectRenderer> { Rename to ...
5 years, 8 months ago (2015-04-16 21:13:42 UTC) #3
pdr.
https://codereview.chromium.org/1092673002/diff/1/Source/core/paint/FilterEffectRenderer.h File Source/core/paint/FilterEffectRenderer.h (right): https://codereview.chromium.org/1092673002/diff/1/Source/core/paint/FilterEffectRenderer.h#newcode42 Source/core/paint/FilterEffectRenderer.h:42: class FilterEffectRenderer final : public RefCountedWillBeGarbageCollectedFinalized<FilterEffectRenderer> { On 2015/04/16 ...
5 years, 8 months ago (2015-04-16 22:01:20 UTC) #4
fs
https://codereview.chromium.org/1092673002/diff/1/Source/core/paint/FilterEffectRenderer.h File Source/core/paint/FilterEffectRenderer.h (right): https://codereview.chromium.org/1092673002/diff/1/Source/core/paint/FilterEffectRenderer.h#newcode42 Source/core/paint/FilterEffectRenderer.h:42: class FilterEffectRenderer final : public RefCountedWillBeGarbageCollectedFinalized<FilterEffectRenderer> { On 2015/04/16 ...
5 years, 8 months ago (2015-04-17 10:56:40 UTC) #5
chrishtr
lgtm
5 years, 8 months ago (2015-04-17 16:46:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092673002/40001
5 years, 8 months ago (2015-04-17 16:47:03 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 16:50:25 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193956

Powered by Google App Engine
This is Rietveld 408576698