Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1092573003: Refactoring: Move a part of creteMarkupInternal to StyledMarkupSerializer (Closed)

Created:
5 years, 8 months ago by hajimehoshi
Modified:
5 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-style_chromium.org, yosin_UTC9
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring: Move a part of creteMarkupInternal to StyledMarkupSerializer createMarkupInternal uses StyledMarkupSerializer as an accumulator of DOM nodes and this is not a proper usage of the serializer. This patch moves a part of createMarkupInternal to StyledMarkupSerializer::createMarkup and hides some member functions of it. By this patch, it will be possible to expose only member functions for serializing of StyledMarkupSerializer. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193922

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : nits: Remove toPositionInDOMTree #

Patch Set 4 : Fix the compile error on Android #

Patch Set 5 : rebase #

Patch Set 6 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -88 lines) Patch
M Source/core/editing/StyledMarkupSerializer.h View 1 2 3 4 3 chunks +9 lines, -6 lines 0 comments Download
M Source/core/editing/StyledMarkupSerializer.cpp View 1 2 3 4 5 3 chunks +114 lines, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 2 3 4 3 chunks +2 lines, -81 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
hajimehoshi
PTAL
5 years, 8 months ago (2015-04-16 10:37:02 UTC) #2
tkent
lgtm
5 years, 8 months ago (2015-04-16 23:13:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092573003/60001
5 years, 8 months ago (2015-04-16 23:13:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/52206)
5 years, 8 months ago (2015-04-16 23:18:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092573003/100001
5 years, 8 months ago (2015-04-17 04:13:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092573003/120001
5 years, 8 months ago (2015-04-17 04:16:53 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 05:35:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193922

Powered by Google App Engine
This is Rietveld 408576698