Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1092573002: [Files.app] Added a tabindex test for save file dialog (Closed)

Created:
5 years, 8 months ago by yoshiki
Modified:
5 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Files.app] Added a tabindex test for save file dialog BUG=469061 TEST=run newly added test Committed: https://crrev.com/0fc95e9d354ebd400120ba30269e9957563e6794 Cr-Commit-Position: refs/heads/master@{#327230}

Patch Set 1 #

Patch Set 2 : rebase and fix test failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -90 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/background.js View 1 1 chunk +52 lines, -0 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/file_dialog.js View 1 4 chunks +32 lines, -71 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/tab_index.js View 1 4 chunks +69 lines, -16 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager_test_manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
yoshiki
@fukino-san, PTAL. Thanks.
5 years, 8 months ago (2015-04-16 08:09:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092573002/1
5 years, 8 months ago (2015-04-16 08:27:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/56758)
5 years, 8 months ago (2015-04-16 08:36:54 UTC) #6
fukino
On 2015/04/16 08:36:54, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-16 11:15:03 UTC) #7
yoshiki
On 2015/04/16 11:15:03, fukino wrote: > On 2015/04/16 08:36:54, I haz the power (commit-bot) wrote: ...
5 years, 8 months ago (2015-04-16 11:16:35 UTC) #8
yoshiki
fukino-san, PTAL again? Thanks.
5 years, 8 months ago (2015-04-27 13:51:28 UTC) #12
fukino
lgtm
5 years, 8 months ago (2015-04-28 03:45:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092573002/80001
5 years, 8 months ago (2015-04-28 03:46:10 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 8 months ago (2015-04-28 04:12:40 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 04:13:37 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0fc95e9d354ebd400120ba30269e9957563e6794
Cr-Commit-Position: refs/heads/master@{#327230}

Powered by Google App Engine
This is Rietveld 408576698