Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1092523002: Whitelist mb files for 'mb analyze', fix Android GN test targets. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist mb files for 'mb analyze', fix Android GN test targets. If one of the tools/mb files changes, mb analyze may not produce correct results (since the configs might change), so we should just build everything. Also, fix a dangling target for the android_gn trybot. TBR=phajdan.jr@chromium.org BUG=454413 Committed: https://crrev.com/94a945cc60ea5ecc1f20252684589e1e7c6295b5 Cr-Commit-Position: refs/heads/master@{#325376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M testing/buildbot/chromium.linux.json View 1 chunk +1 line, -5 lines 0 comments Download
M testing/buildbot/trybot_analyze_config.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
5 years, 8 months ago (2015-04-15 22:54:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092523002/1
5 years, 8 months ago (2015-04-15 22:55:31 UTC) #3
Paweł Hajdan Jr.
LGTM FWIW it seems this could be done in two separate patches as the two ...
5 years, 8 months ago (2015-04-15 23:51:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 02:14:34 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 02:15:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94a945cc60ea5ecc1f20252684589e1e7c6295b5
Cr-Commit-Position: refs/heads/master@{#325376}

Powered by Google App Engine
This is Rietveld 408576698