Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1092513003: Open search result of drive search in Chrome Launcher. (Closed)

Created:
5 years, 8 months ago by yawano
Modified:
5 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Open search result of drive search in Chrome Launcher. If a search result is a directory, open it with file manager. If a search result is a file, try to execute default task. When it fails, opens a file manager with selecting the entry. BUG=440649 TEST=manually tested; Enable launcher-search-provider-api flag, type some query in chrome launcher. Click the search result and confirm that the result is opened. Committed: https://crrev.com/57fa64e5129376ec06a75131acbdf8b4ea38c8df Cr-Commit-Position: refs/heads/master@{#325999}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M ui/file_manager/externs/launcher_search_provider.js View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/background/js/launcher_search.js View 1 4 chunks +68 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
yawano
PTAL. Thank you!
5 years, 8 months ago (2015-04-21 08:16:03 UTC) #2
fukino
LGTM with nits. https://codereview.chromium.org/1092513003/diff/1/ui/file_manager/file_manager/background/js/launcher_search.js File ui/file_manager/file_manager/background/js/launcher_search.js (right): https://codereview.chromium.org/1092513003/diff/1/ui/file_manager/file_manager/background/js/launcher_search.js#newcode153 ui/file_manager/file_manager/background/js/launcher_search.js:153: /* App ID */ undefined, nit: ...
5 years, 8 months ago (2015-04-21 08:52:47 UTC) #3
yawano
Thank you! https://codereview.chromium.org/1092513003/diff/1/ui/file_manager/file_manager/background/js/launcher_search.js File ui/file_manager/file_manager/background/js/launcher_search.js (right): https://codereview.chromium.org/1092513003/diff/1/ui/file_manager/file_manager/background/js/launcher_search.js#newcode153 ui/file_manager/file_manager/background/js/launcher_search.js:153: /* App ID */ undefined, On 2015/04/21 ...
5 years, 8 months ago (2015-04-21 08:58:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092513003/20001
5 years, 8 months ago (2015-04-21 08:59:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 09:28:48 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 09:29:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57fa64e5129376ec06a75131acbdf8b4ea38c8df
Cr-Commit-Position: refs/heads/master@{#325999}

Powered by Google App Engine
This is Rietveld 408576698